It involves removing all 51 instances of IsRunningOnIOS9OrLater().
Needs owner and milestone.
Also IsRunningOnIOS8OrLater()
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a29c5278349056b612dcad4efe6257e13ee20149 commit a29c5278349056b612dcad4efe6257e13ee20149 Author: pkl <pkl@chromium.org> Date: Mon Oct 17 14:21:40 2016 Removed use of IsRunningOnIOS8OrLater BUG= 633626 Review-Url: https://codereview.chromium.org/2425543002 Cr-Commit-Position: refs/heads/master@{#425677} [modify] https://crrev.com/a29c5278349056b612dcad4efe6257e13ee20149/ios/chrome/browser/passwords/credential_manager.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/52eaef815d1515e57b8561eddaa5bdba79986d19 commit 52eaef815d1515e57b8561eddaa5bdba79986d19 Author: pkl <pkl@google.com> Date: Mon Oct 17 15:09:43 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2036daa3410420a709f3af8a6fef5e22190be6c5 commit 2036daa3410420a709f3af8a6fef5e22190be6c5 Author: pkl <pkl@chromium.org> Date: Mon Oct 17 15:08:14 2016 Removed use of IsRunningOnIOS8OrLater() BUG= 633626 Review-Url: https://codereview.chromium.org/2419343002 Cr-Commit-Position: refs/heads/master@{#425679} [modify] https://crrev.com/2036daa3410420a709f3af8a6fef5e22190be6c5/ios/chrome/browser/memory/memory_debugger.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9aad551e547568079ac2b2915fa1a0a1937b265a commit 9aad551e547568079ac2b2915fa1a0a1937b265a Author: pkl <pkl@google.com> Date: Mon Oct 17 18:43:27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9e3f934083ae58c9d6d19f1a9e32f8732e5cece commit d9e3f934083ae58c9d6d19f1a9e32f8732e5cece Author: pkl <pkl@chromium.org> Date: Mon Oct 17 20:43:30 2016 Removed use of IsRunningOnIOS8OrLater BUG= 633626 Review-Url: https://codereview.chromium.org/2423803002 Cr-Commit-Position: refs/heads/master@{#425770} [modify] https://crrev.com/d9e3f934083ae58c9d6d19f1a9e32f8732e5cece/ios/net/cookies/cookie_creation_time_manager_unittest.mm [modify] https://crrev.com/d9e3f934083ae58c9d6d19f1a9e32f8732e5cece/ios/net/cookies/cookie_store_ios.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/22e5b19ed94d1d87b1cbf6cdcb2ecc5cacb2aeef commit 22e5b19ed94d1d87b1cbf6cdcb2ecc5cacb2aeef Author: pkl <pkl@google.com> Date: Mon Oct 17 21:09:49 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045dd132e8d0a1ff6f067de23bf34516faf3ecf8 commit 045dd132e8d0a1ff6f067de23bf34516faf3ecf8 Author: pkl <pkl@chromium.org> Date: Tue Oct 18 16:15:22 2016 Removed unused include file in credential_manager. This should have been part of https://codereview.chromium.org/2425543002/ BUG= 633626 Review-Url: https://codereview.chromium.org/2425933003 Cr-Commit-Position: refs/heads/master@{#425983} [modify] https://crrev.com/045dd132e8d0a1ff6f067de23bf34516faf3ecf8/ios/chrome/browser/passwords/credential_manager.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/770fdb9d6d2a8a7f0836bff8e46675d8fbb4c648 commit 770fdb9d6d2a8a7f0836bff8e46675d8fbb4c648 Author: pkl <pkl@google.com> Date: Tue Oct 18 17:10:54 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0b6434601f91eb716f794ecde6b3292bdacfebe2 commit 0b6434601f91eb716f794ecde6b3292bdacfebe2 Author: pkl <pkl@google.com> Date: Tue Oct 18 20:47:20 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1dbed24625dfd5190faf542e04e3116b9893326b commit 1dbed24625dfd5190faf542e04e3116b9893326b Author: pkl <pkl@google.com> Date: Tue Oct 18 21:10:27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/16629991b76597cf024980ff5baf18a869c3cb95 commit 16629991b76597cf024980ff5baf18a869c3cb95 Author: pkl <pkl@google.com> Date: Tue Oct 18 21:33:43 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0bac5e54025120741581c3467004a3e26c2ac158 commit 0bac5e54025120741581c3467004a3e26c2ac158 Author: pkl <pkl@google.com> Date: Wed Oct 19 12:51:42 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/56308cea20534cf20f638e31830c0ec5207b5dc2 commit 56308cea20534cf20f638e31830c0ec5207b5dc2 Author: pkl <pkl@google.com> Date: Wed Oct 19 14:25:13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/755812372f8ff7c66db33d0cae9fae8d9fe03ba2 commit 755812372f8ff7c66db33d0cae9fae8d9fe03ba2 Author: pkl <pkl@google.com> Date: Wed Oct 19 17:06:18 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/64bf44df08dd5fc6564a4f25848e6dcf24759c71 commit 64bf44df08dd5fc6564a4f25848e6dcf24759c71 Author: pkl <pkl@google.com> Date: Wed Oct 19 17:32:35 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a090419a7c2db425450ba531db9d2c5d6b838868 commit a090419a7c2db425450ba531db9d2c5d6b838868 Author: pkl <pkl@chromium.org> Date: Wed Oct 19 19:37:14 2016 Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util BUG= 633626 Review-Url: https://chromiumcodereview.appspot.com/2430463003 Cr-Commit-Position: refs/heads/master@{#426260} [modify] https://crrev.com/a090419a7c2db425450ba531db9d2c5d6b838868/ios/chrome/browser/ui/ui_util.mm [modify] https://crrev.com/a090419a7c2db425450ba531db9d2c5d6b838868/ios/chrome/browser/ui/uikit_ui_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4871f54fb3881f41eed46f677a3824177ab92355 commit 4871f54fb3881f41eed46f677a3824177ab92355 Author: pkl <pkl@chromium.org> Date: Wed Oct 19 21:24:47 2016 Removed use of IsRunningOnIOS8OrLater from snapshots code. BUG= 633626 Review-Url: https://chromiumcodereview.appspot.com/2426823002 Cr-Commit-Position: refs/heads/master@{#426287} [modify] https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm [modify] https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355/ios/chrome/browser/snapshots/snapshots_util.mm [modify] https://crrev.com/4871f54fb3881f41eed46f677a3824177ab92355/ios/chrome/browser/snapshots/snapshots_util_unittest.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8cfe924c70e4786ccbab6f9f6d17d306f5a57e4b commit 8cfe924c70e4786ccbab6f9f6d17d306f5a57e4b Author: pkl <pkl@google.com> Date: Wed Oct 19 23:36:15 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a4c85129280ca2666aeac75a393f8073b90fbefd commit a4c85129280ca2666aeac75a393f8073b90fbefd Author: pkl <pkl@google.com> Date: Wed Oct 19 23:36:23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/23aeb3e2d39e12f7fb6a1b678d77399250885a4a commit 23aeb3e2d39e12f7fb6a1b678d77399250885a4a Author: pkl <pkl@google.com> Date: Thu Oct 20 09:17:01 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4df605a095f1e5b2c327ff6d34278d1d25c50460 commit 4df605a095f1e5b2c327ff6d34278d1d25c50460 Author: pkl <pkl@chromium.org> Date: Thu Oct 20 13:37:21 2016 Removed use of IsRunningOnIOS9OrLater from rtl_geometry.mm BUG= 633626 Review-Url: https://chromiumcodereview.appspot.com/2437573004 Cr-Commit-Position: refs/heads/master@{#426466} [modify] https://crrev.com/4df605a095f1e5b2c327ff6d34278d1d25c50460/ios/chrome/browser/ui/rtl_geometry.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8f0c13315226f78b1a3b4779f70feb9bf2495d1 commit c8f0c13315226f78b1a3b4779f70feb9bf2495d1 Author: pkl <pkl@chromium.org> Date: Thu Oct 20 16:16:03 2016 Remove IDC_BACK_TO_CALLING_APP which is now obsolete This depends on https://chromereviews.googleplex.com/523537014 which deleted the code for Back to Calling App button. BUG= 633626 Review-Url: https://chromiumcodereview.appspot.com/2427883002 Cr-Commit-Position: refs/heads/master@{#426490} [modify] https://crrev.com/c8f0c13315226f78b1a3b4779f70feb9bf2495d1/ios/chrome/browser/ui/commands/ios_command_ids.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9a76911ce798c20fa17fe49c5b6dfe3eec94e3c0 commit 9a76911ce798c20fa17fe49c5b6dfe3eec94e3c0 Author: pkl <pkl@google.com> Date: Thu Oct 20 17:07:44 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/62036c8d1d3d79e2e4ec6a495a9d67a6d9004e09 commit 62036c8d1d3d79e2e4ec6a495a9d67a6d9004e09 Author: pkl <pkl@google.com> Date: Fri Oct 21 00:21:08 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c2d8106eaf7b77a49f1d95d5dff4ee07a69ef224 commit c2d8106eaf7b77a49f1d95d5dff4ee07a69ef224 Author: pkl <pkl@google.com> Date: Fri Oct 21 00:45:32 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/26213df9b801c33612c917ec77981cf66be2c294 commit 26213df9b801c33612c917ec77981cf66be2c294 Author: pkl <pkl@google.com> Date: Fri Oct 21 03:26:25 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/58c4ff52f957cb3a8d58140ceb807d6031b47a44 commit 58c4ff52f957cb3a8d58140ceb807d6031b47a44 Author: pkl <pkl@google.com> Date: Fri Oct 21 17:29:59 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7070deba73f5befc29c214b1b44779f7c81358 commit cf7070deba73f5befc29c214b1b44779f7c81358 Author: pkl <pkl@chromium.org> Date: Mon Oct 24 18:54:55 2016 Removed uses of IsRunningOnIOS9OrLater in crw_web_ or wk_web_view_ BUG= 633626 Review-Url: https://codereview.chromium.org/2436903002 Cr-Commit-Position: refs/heads/master@{#427108} [modify] https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358/ios/web/test/wk_web_view_crash_utils.mm [modify] https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358/ios/web/web_state/crw_web_view_proxy_impl.mm [modify] https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/cf7070deba73f5befc29c214b1b44779f7c81358/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
We should also remove runtime checks with +instancesRespondToSelector: and -respondsToSelector: for APIs introduced in iOS 9 and below.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/533c85ee8dd1a3799a665e1f26c947cc177f0330 commit 533c85ee8dd1a3799a665e1f26c947cc177f0330 Author: pkl <pkl@google.com> Date: Mon Nov 07 21:22:08 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9a2373b9f23e7447c8347881278974e29969cd2b commit 9a2373b9f23e7447c8347881278974e29969cd2b Author: pkl <pkl@google.com> Date: Wed Nov 09 01:09:49 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e465fbb8dd28195ca3076539d20c819aa6c383f commit 4e465fbb8dd28195ca3076539d20c819aa6c383f Author: pkl <pkl@chromium.org> Date: Wed Nov 09 02:30:44 2016 Remove unnecessary check for iOS 8 in handoff_manager.mm BUG= 633626 Review-Url: https://codereview.chromium.org/2487073002 Cr-Commit-Position: refs/heads/master@{#430834} [modify] https://crrev.com/4e465fbb8dd28195ca3076539d20c819aa6c383f/components/handoff/handoff_manager.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5640ffb6b93a7332e4c9ce21c41bbc3a3f84aafa commit 5640ffb6b93a7332e4c9ce21c41bbc3a3f84aafa Author: pkl <pkl@chromium.org> Date: Thu Nov 10 14:58:36 2016 Last step of removing IsRunningOnIOS8OrLater() BUG= 633626 Review-Url: https://codereview.chromium.org/2486363002 Cr-Commit-Position: refs/heads/master@{#431255} [modify] https://crrev.com/5640ffb6b93a7332e4c9ce21c41bbc3a3f84aafa/base/ios/ios_util.h [modify] https://crrev.com/5640ffb6b93a7332e4c9ce21c41bbc3a3f84aafa/base/ios/ios_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61a0ee576866db5db5d7dd2465b5b75ee70089bf commit 61a0ee576866db5db5d7dd2465b5b75ee70089bf Author: gambard <gambard@chromium.org> Date: Mon Jan 30 15:13:17 2017 Re-enable WebP tests It is passing on devices. BUG=523235, 633626 Review-Url: https://codereview.chromium.org/2665673002 Cr-Commit-Position: refs/heads/master@{#446982} [modify] https://crrev.com/61a0ee576866db5db5d7dd2465b5b75ee70089bf/ios/web/public/image_fetcher/image_data_fetcher_unittest.mm [modify] https://crrev.com/61a0ee576866db5db5d7dd2465b5b75ee70089bf/ios/web/public/image_fetcher/webp_decoder_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2affa91c404bd93f81fdab4af5e6576abd64aeb2 commit 2affa91c404bd93f81fdab4af5e6576abd64aeb2 Author: pkl <pkl@chromium.org> Date: Wed Feb 22 15:23:20 2017 Remove IsRunningOnIOS9OrLater check from elide_url_unittest iOS 9 is the minimum requirement. BUG= 633626 Review-Url: https://codereview.chromium.org/2694363004 Cr-Commit-Position: refs/heads/master@{#452057} [modify] https://crrev.com/2affa91c404bd93f81fdab4af5e6576abd64aeb2/components/url_formatter/elide_url_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/854676c0fda8a9195d899e8ed5632e85f9446df2 commit 854676c0fda8a9195d899e8ed5632e85f9446df2 Author: pkl <pkl@chromium.org> Date: Wed Feb 22 15:43:51 2017 Remove IsRunningOnIOS9OrLater() check from uikit_ui_util iOS 9 is the minimum requirement now. BUG= 633626 Review-Url: https://codereview.chromium.org/2692043010 Cr-Commit-Position: refs/heads/master@{#452066} [modify] https://crrev.com/854676c0fda8a9195d899e8ed5632e85f9446df2/ios/chrome/browser/ui/uikit_ui_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d155163c0ffe96e22b9432fd6978bd7bcb9f15f commit 5d155163c0ffe96e22b9432fd6978bd7bcb9f15f Author: pkl <pkl@chromium.org> Date: Wed Feb 22 19:08:45 2017 Remove IsRunningOnIOS9OrLater() check from omnibox_text_field_ios iOS 9 is now the minimum supported OS version. BUG= 633626 Review-Url: https://codereview.chromium.org/2695243003 Cr-Commit-Position: refs/heads/master@{#452154} [modify] https://crrev.com/5d155163c0ffe96e22b9432fd6978bd7bcb9f15f/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e6615d393c1db3af2cb21604815e43f26e8e73 commit 93e6615d393c1db3af2cb21604815e43f26e8e73 Author: pkl <pkl@chromium.org> Date: Wed Feb 22 23:57:04 2017 Remove IsRunningOnIOS9OrLater(). No more users of this call. BUG= 633626 Review-Url: https://codereview.chromium.org/2711463006 Cr-Commit-Position: refs/heads/master@{#452285} [modify] https://crrev.com/93e6615d393c1db3af2cb21604815e43f26e8e73/base/ios/ios_util.h [modify] https://crrev.com/93e6615d393c1db3af2cb21604815e43f26e8e73/base/ios/ios_util.mm
Final CL removed IsRunningOnIOS9OrLater()
Comment 1 by pkl@chromium.org
, Aug 9 2016Labels: M-55
Owner: pkl@chromium.org
Status: Assigned (was: Available)