New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633617 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 628022

Blocking:
issue 883308



Sign in to add a comment

mac_optional_gpu_tests_rel runs entire test suite when running without patch

Project Member Reported by xidac...@chromium.org, Aug 2 2016

Issue description

Please refer to this as an example:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/2414

webgl2_conformance_tests on NVIDIA GPU on Mac Retina (with patch) on Mac fails one test, and later one it goes:

webgl2_conformance_tests on NVIDIA GPU on Mac Retina (without patch) on Mac 

The step of "without patch" takes longer than "with patch", it seems like in the "without patch", the entire suite is running. Is this work as intended?
 

Comment 2 by kbr@chromium.org, Aug 3 2016

Blockedon: 628022
Cc: dpranke@chromium.org eyaich@chromium.org tandrii@chromium.org
Components: -Blink>Infra Internals>GPU>Testing Infra>Platform>Recipes
Owner: phajdan.jr@chromium.org
The problem of entire shards failing is  Issue 628022 . I'll comment there on the whole-shard failures.

I don't know how to turn off the "without patch" steps in the chromium_trybot recipe. Pawel, can you offer advice? I think we want to change this bot's configuration so that it never does the retries without the patch.

You would want to touch https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?q=chromium_tests/api&sq=package:chromium&l=678

It doesn't look like it's configurable at the moment. Pawel would know more about this. 
Status: Assigned (was: Untriaged)

Comment 5 by kbr@chromium.org, Aug 5 2016

Pawel, could you help make this flag configurable somehow? Perhaps in a file like scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py , and have the tryserver which mirrors that bot pick up the flag from there? I realize there's a problem with the generalized trybot mirroring wanting flags like this configured identically across all the mirrored bots. Would appreciate help thinking this through and implementing it. Thanks.

Owner: phajdan@google.com
Labels: -Pri-3 Pri-2
Cc: phajdan@google.com
Components: -Infra>Platform>Recipes Infra>Client>Chrome
Owner: phajdan.jr@chromium.org
Status: Started (was: Assigned)
Uploaded https://codereview.chromium.org/2327543002 .
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 9 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035e5f844b6af5db212f9dfeabf7b2cf9225b9f4

commit 035e5f844b6af5db212f9dfeabf7b2cf9225b9f4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 09:22:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f chromium_tests: add an option to disable deapplying patch on some trybots (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 633617 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2325083002
Cr-Commit-Position: refs/heads/master@{#417542}

[modify] https://crrev.com/035e5f844b6af5db212f9dfeabf7b2cf9225b9f4/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/84f5467b87a81f6ec315608eeede0cefb5dfd671

commit 84f5467b87a81f6ec315608eeede0cefb5dfd671
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 09:24:56 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f chromium_tests: add an option to disable deapplying patch on some trybots (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 633617 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323243002

[modify] https://crrev.com/84f5467b87a81f6ec315608eeede0cefb5dfd671/infra/config/recipes.cfg

Status: Fixed (was: Started)
Blocking: 883308

Sign in to add a comment