mac_optional_gpu_tests_rel runs entire test suite when running without patch |
||||||||
Issue descriptionPlease refer to this as an example: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/2414 webgl2_conformance_tests on NVIDIA GPU on Mac Retina (with patch) on Mac fails one test, and later one it goes: webgl2_conformance_tests on NVIDIA GPU on Mac Retina (without patch) on Mac The step of "without patch" takes longer than "with patch", it seems like in the "without patch", the entire suite is running. Is this work as intended?
,
Aug 3 2016
The problem of entire shards failing is Issue 628022 . I'll comment there on the whole-shard failures. I don't know how to turn off the "without patch" steps in the chromium_trybot recipe. Pawel, can you offer advice? I think we want to change this bot's configuration so that it never does the retries without the patch.
,
Aug 3 2016
You would want to touch https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?q=chromium_tests/api&sq=package:chromium&l=678 It doesn't look like it's configurable at the moment. Pawel would know more about this.
,
Aug 3 2016
,
Aug 5 2016
Pawel, could you help make this flag configurable somehow? Perhaps in a file like scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py , and have the tryserver which mirrors that bot pick up the flag from there? I realize there's a problem with the generalized trybot mirroring wanting flags like this configured identically across all the mirrored bots. Would appreciate help thinking this through and implementing it. Thanks.
,
Sep 2 2016
,
Sep 2 2016
,
Sep 8 2016
Uploaded https://codereview.chromium.org/2327543002 .
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/80542c017e711600a8952f4fc8de126ca04b5c7f commit 80542c017e711600a8952f4fc8de126ca04b5c7f Author: phajdan.jr <phajdan.jr@chromium.org> Date: Fri Sep 09 09:08:02 2016 chromium_tests: add an option to disable deapplying patch on some trybots BUG= 633617 Review-Url: https://codereview.chromium.org/2327543002 [modify] https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f/scripts/slave/recipe_modules/chromium_tests/api.py [modify] https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f/scripts/slave/recipe_modules/chromium_tests/trybots.py [add] https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json [modify] https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f/scripts/slave/recipes/chromium_trybot.py
,
Sep 9 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b0a3e2ab5a83cc5bbc1847815776a497c4ce35a0 commit b0a3e2ab5a83cc5bbc1847815776a497c4ce35a0 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 09 09:13:54 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/035e5f844b6af5db212f9dfeabf7b2cf9225b9f4 commit 035e5f844b6af5db212f9dfeabf7b2cf9225b9f4 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 09 09:22:55 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f chromium_tests: add an option to disable deapplying patch on some trybots (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 633617 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2325083002 Cr-Commit-Position: refs/heads/master@{#417542} [modify] https://crrev.com/035e5f844b6af5db212f9dfeabf7b2cf9225b9f4/infra/config/recipes.cfg
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/84f5467b87a81f6ec315608eeede0cefb5dfd671 commit 84f5467b87a81f6ec315608eeede0cefb5dfd671 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 09 09:24:56 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/80542c017e711600a8952f4fc8de126ca04b5c7f chromium_tests: add an option to disable deapplying patch on some trybots (phajdan.jr@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 633617 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2323243002 [modify] https://crrev.com/84f5467b87a81f6ec315608eeede0cefb5dfd671/infra/config/recipes.cfg
,
Sep 9 2016
,
Sep 14
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by xidac...@chromium.org
, Aug 2 2016