New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Only one PaymentRequest UI should be shown at a time.

Project Member Reported by rouslan@chromium.org, Aug 2 2016

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8401134848abbb32f99de0f188f730f706e9ae42

commit 8401134848abbb32f99de0f188f730f706e9ae42
Author: rouslan <rouslan@chromium.org>
Date: Tue Aug 02 23:10:34 2016

Show at most one PaymentRequest UI at a time.

If the webpage calls PaymentRequest.show() while another
PaymentRequest UI is already showing, then reject the second
show() promise.

In addition, this patch performs "OK to create
PaymentRequest" checks inside of the PaymentRequestFactory
instead of the PaymentRequestImpl constructor. That way
PaymentRequestImpl is guaranteed to have a valid state.
This allows many variables in PaymentRequestImpl to become
final.

BUG= 633610 

Review-Url: https://codereview.chromium.org/2192423002
Cr-Commit-Position: refs/heads/master@{#409371}

[modify] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/android/java_sources.gni
[add] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[add] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/test/data/android/payments/payment_request_show_twice_test.html
[add] https://crrev.com/8401134848abbb32f99de0f188f730f706e9ae42/chrome/test/data/android/payments/show_twice.js

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment