New issue
Advanced search Search tips

Issue 633605 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Create scrollable OptIn content

Project Member Reported by khmel@chromium.org, Aug 2 2016

Issue description

In case OptIn window is smaller then required due low resolution,  Start Page and LSO content must be scrollable.

Inner bug - b/29817065
CL: https://codereview.chromium.org/2142933006/
 

Comment 1 by khmel@chromium.org, Aug 2 2016

Status: Fixed (was: Started)

Comment 2 by dimu@chromium.org, Aug 3 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3992e34ca2a88389f9d8621a9bb937f2b12d408

commit e3992e34ca2a88389f9d8621a9bb937f2b12d408
Author: Xiyuan Xia <xiyuan@google.com>
Date: Wed Aug 03 16:30:28 2016

Merge "arc: Implement scrollable OptIn window content."

> Support low resolutions by making OptIn content scrollable in case
> Chrome desktop resolution is lower than required for normal OptIn
> display. This also implements automatic window bounds update on
> desktop resoluton change.
>
> BUG=b/29817065
> TEST=Manually on devices.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2142933006
> Cr-Commit-Position: refs/heads/master@{#404947}
> (cherry picked from commit f8e016bfad2544663aab1bdcccd652477cbfbfe2)

BUG= 633605 

Review URL: https://codereview.chromium.org/2206953003 .

Cr-Commit-Position: refs/branch-heads/2785@{#487}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/chromeos/arc/arc_support_host.h
[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/resources/chromeos/arc_support/background.js
[add] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/resources/chromeos/arc_support/lso.css
[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/e3992e34ca2a88389f9d8621a9bb937f2b12d408/chrome/browser/resources/component_extension_resources.grd

Status: Verified (was: Fixed)

Sign in to add a comment