Unnecessary navigation to 'chrome://history/syncedTabs' is seen after click on 'Advanced sync settings'
Reported by
dmascare...@etouch.net,
Aug 2 2016
|
||||||
Issue descriptionChrome Version:54.0.2816.0 (Official Build) 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090} (32/64-bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://history/syncedTabs 2. Click on "SIGN IN TO CHROME" Button and signin with valid credential(which have passphrase)such that 'Sync confirmation’ overlay is opened. 3. Click on 'Settings' link of the overlay such that 'chrome://settings/syncSetup' overlay gets open. 4. Add the valid passphrase,click on 'Ok' button and again navigate to chrome://history/syncedTabs (reload the page),click on "SIGN IN TO CHROME" Button 5. Now navigate to chrome://settings/ and click on 'Advanced sync settings',observe. Actual: Unnecessary browser navigates to 'chrome://history/syncedTabs' page after step 5. Expected:'Sync confirmation’ overlay should get open after step 5. This is non-regression issue, seen from 'M-53' as "SIGN IN TO CHROME" Button in "Synced Tabs" is introduced from 53.0.2776.0 @lshang: Please take a look
,
Aug 3 2016
,
Aug 8 2016
I can see 2 bugs in the screen capture: 1. "SIGN IN TO CHROME" should not be seen after user has already signed in but disabled tab sync and reload history page. This has already been fixed in https://codereview.chromium.org/2191173003/. 2. synced tabs page keeps showing 'loading' after tab sync is disabled and reload. I'm setting up a CL to fix this.
,
Aug 9 2016
,
Aug 9 2016
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaca255abd350f4d3b85ccff3d3dec1358255313 commit aaca255abd350f4d3b85ccff3d3dec1358255313 Author: lshang <lshang@chromium.org> Date: Wed Aug 10 03:27:45 2016 MD History: Show 'no synced tabs' when tab sync is disabled When user signs in and disables tab sync, setForeignSessions will return directly, leaving "Loading" message shown in synced tabs page. This CL notifies synced device manager to change message from "Loading" to "No synced devices" when tab sync is disabled. BUG= 633558 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2220303002 Cr-Commit-Position: refs/heads/master@{#410943} [modify] https://crrev.com/aaca255abd350f4d3b85ccff3d3dec1358255313/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/aaca255abd350f4d3b85ccff3d3dec1358255313/chrome/browser/resources/md_history/synced_device_manager.js [modify] https://crrev.com/aaca255abd350f4d3b85ccff3d3dec1358255313/chrome/test/data/webui/md_history/history_synced_tabs_test.js
,
Aug 18 2016
,
Aug 19 2016
Above is seems to be fix on Latest Dev Chrome Version:54.0.2832.2 (Official Build)373f6bdd42a605a49fa170b2bcdbae3fbd015acc-refs/branch-heads/2832@{#3}
,
Aug 19 2016
As per Comment# 8, adding TE-Verified Labels. Just to update, issue is no more reproducible on Windows, Mac and Linux. Thank You. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ranjitkan@chromium.org
, Aug 2 2016