New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633556 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [History] Tooltip doesn't appear for toolbar menu button.

Reported by dchau...@etouch.net, Aug 2 2016

Issue description

Chrome Version: 54.0.2816.0 (Official Build) 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090} 32/64-bit.
OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://history page and restore down the browser.
2. Resize the browser from RHS to LHS such that toolbar menu button appears.
3. Now, hover the mouse pointer on toolbar menu button and observe.

Tooltip doesn't display for toolbar menu button.
Tooltip should display for toolbar menu button.

This is a regression issue, broken in M-53 series, below is bisect info.

Good build: 53.0.2784.0 
Bad build: 53.0.2785.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/4c308755fb630932b58e08786e30ef081238da99..a7567e712c264712d0d473dc9d873c64f3247fe0?pretty=fuller&n=100

Suspecting: r403098

Kindly review the attached screen-cast for reference.
 
Tooltip Actual.mp4
663 KB View Download
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: lshang@chromium.org

Comment 4 by lshang@chromium.org, Aug 11 2016

Cc: -lshang@chromium.org tsergeant@chromium.org
Owner: lshang@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874ed7b5e521c6cf2687b7f12dc09c44f48f206a

commit 874ed7b5e521c6cf2687b7f12dc09c44f48f206a
Author: lshang <lshang@chromium.org>
Date: Fri Aug 19 03:13:11 2016

MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also use
<cr-toolbar>.

BUG= 633556 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2235803003
Cr-Commit-Position: refs/heads/master@{#413042}

[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/app/generated_resources.grd
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/app/settings_strings.grdp
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Status: Fixed (was: Assigned)

Sign in to add a comment