New issue
Advanced search Search tips

Issue 633550 link

Starred by 4 users
Status: Duplicate
Merged: issue webrtc:7062
Owner:
hbos@chromium.org
Closed: Jan 2017
Cc:
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue webrtc:5361
issue webrtc:6450
issue 653873
issue 654927
issue webrtc:6755
Blocking:
issue 627816



Sign in to add a comment

RTCPeerConnection.getStats: RTCIceCandidatePairStats

Project Member Reported by hbos@chromium.org, Aug 2 2016 
Add RTCIceCandidatePairStats and all of its members.
http://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html#candidatepair-dict*

dictionary RTCIceCandidatePairStats : RTCStats {
    DOMString                     transportId;
    DOMString                     localCandidateId;
    DOMString                     remoteCandidateId;
    RTCStatsIceCandidatePairState state;
    unsigned long long            priority;
    boolean                       nominated;
    boolean                       writable;
    boolean                       readable;
    unsigned long long            bytesSent;
    unsigned long long            bytesReceived;
    double                        roundTripTime;
    double                        availableOutgoingBitrate;
    double                        availableIncomingBitrate;
};

Comment 1 by hbos@chromium.org, Oct 3 2016

Blockedon: webrtc:6450 webrtc:5361

Comment 2 by hbos@chromium.org, Oct 7 2016

Cc: hta@chromium.org

Comment 3 by hbos@chromium.org, Oct 7 2016

Blockedon: 653873

Comment 4 by hbos@chromium.org, Oct 7 2016

Blocking: 653873

Comment 6 by hbos@chromium.org, Oct 11 2016

Blocking: -653873

Comment 7 by hbos@chromium.org, Oct 11 2016

Blockedon: 654927

Comment 9 by hbos@webrtc.org, Nov 23 2016

Blockedon: webrtc:6755
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e448dd53554b4ecd3dd62a46a08b25044bc2e210

commit e448dd53554b4ecd3dd62a46a08b25044bc2e210
Author: hbos <hbos@webrtc.org>
Date: Mon Dec 12 09:22:53 2016

RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentrequestssent

BUG= chromium:633550 

Review-Url: https://codereview.webrtc.org/2558293002
Cr-Commit-Position: refs/heads/master@{#15541}

[modify] https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210/webrtc/api/stats/rtcstats_objects.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe

commit 06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe
Author: hbos <hbos@webrtc.org>
Date: Mon Jan 02 16:08:18 2017

RTCIceCandidatePairStats.[state/priority] added, ConnectionInfo updated.

State and priority added to ConnectionInfo. The Connection::State enum
is replaced by IceCandidatePairState enum class.

At P2PTransportChannel::GetStats, Connection::stats is called, producing
ConnectionInfo for the connection that is then filled in with additional
values from the Connection. This is refactored so that all values are
set by Connection::stats.

RTCStatsCollector is updated to surface the ConnectionInfo stats.

BUG= webrtc:6755 ,  chromium:633550 ,  chromium:627816 

Review-Url: https://codereview.webrtc.org/2597423003
Cr-Commit-Position: refs/heads/master@{#15870}

[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/jseptransport.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/jseptransport.h
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/p2ptransportchannel.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/p2ptransportchannel_unittest.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/port.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/port.h
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/p2p/base/turnport_unittest.cc
[modify] https://crrev.com/06495bcbb7477b8df1e9f2e34eae0efd11e0b9fe/webrtc/stats/rtcstats_objects.cc

Comment 13 by hbos@chromium.org, Jan 26 2017

Mergedinto: webrtc:7062
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.
►

Sign in to add a comment