Regression: On opening Switch person window, unnecessary blink of text is seen at the bottom.
Reported by
vvishwak...@etouch.net,
Aug 2 2016
|
|||||
Issue descriptionVersion: 54.0.2816.0 (Official Build) 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090} (32/64-bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, go to chrome://settings, from ‘People’ section, uncheck ‘Enable Guest browsing’ and ‘Let anyone…’ options. 2) Click on avatar icon, select ‘Switch person’ and observe the bottom side of Switch person window. Blink of ‘Browse as Guest’ and ‘Add person’ options is seen at bottom. Blink of ‘Browse as Guest’ and ‘Add person’ options should not be seen at bottom. This is a Regression issue broken in M-51 series, below is the bisect info Manual bisect: Good build: 52.0.2706.0 Bad build: 52.0.2707.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/ed75dc7053dc072bdd0e72f64a869d59ec587f4b..3ce610430e914400d917c949d2811293c28505b9?pretty=fuller&n=100 Suspecting: r386786
,
Aug 2 2016
I can't reproduce this on Canary 54.0.2816.0, Win10 nor on Mac. Does this reproduce on multiple machines? Also, TextAutosizer is only for Android, so this should be from other CLs if constantly reproducible.
,
Aug 3 2016
With response to comment #2: Above issue is reproducible on latest Canary 54.0.2817.0 on Windows and Mac OS. Issue is reproducible on multiple machines.
,
Aug 8 2016
I still can't reproduce. Also TextAutosizer kicks in only for mobile, so if it reproduces on Win/Mac, it should be from something else. jdufault@, happen to have any ideas?
,
Aug 8 2016
Passing to sammiequon@ who has been making a fair number of changes in that code-base lately.
,
Aug 9 2016
I checkout the latest commit on the given bisect but could not reproduce. vvishwakarma@, happen to have any more details?
,
Aug 10 2016
With response to comment #6: The above issue is reproducible on latest Canary build: 54.0.2824.0. The issue is reproducible consistently on a newly added user.
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c6fc7e0f53ace3e0e4be7959dfc1942917c117b commit 0c6fc7e0f53ace3e0e4be7959dfc1942917c117b Author: sammiequon <sammiequon@chromium.org> Date: Tue Oct 04 00:04:48 2016 cros: Backspace button changes sizes. Fix bug where disabled backspace button would be a bit too small. Also fix bug where chrome user pods were not transitioning. BUG=651954, 633542 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2389013002 Cr-Commit-Position: refs/heads/master@{#422611} [modify] https://crrev.com/0c6fc7e0f53ace3e0e4be7959dfc1942917c117b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/0c6fc7e0f53ace3e0e4be7959dfc1942917c117b/ui/login/account_picker/user_pod_row.css
,
Oct 27 2016
I think the previous CL referenced this bug by mistake, but I do not see this on the latest build. vvishwakarma@ - Can you confirm this?
,
Dec 8 2016
Able to reproduce the issue on Windows 10, Mac 10.12.1 and Ubuntu 14.04 using chrome version #54.0.2840.99 but the same is not reproducible in the latest stable #55.0.2883.75 and latest canary #57.0.2944.0. Reverse Bisect Information: ===================== Good build: 55.0.2856.0 Revision(417772) Bad Build : 55.0.2855.0 Revision(417475) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/fdae1ec9baa35c06de65e8b823336c5772e7060e..f3ebdac066bc591fd3dbe8400bd527e6c027e38e From the above change log possible CL that fixed this issue: Review-Url: https://codereview.chromium.org/2324153002 mahmadi@ - Could you please check and merge the fix to M55 if it is a valid canadidate. Thanks...!!
,
Dec 16 2016
mahmadi@ Gentle Ping! Could you please respond for the comment #10. Thanks!
,
Dec 16 2016
why is a merge necessary if this is not reproducible in stable #55?
,
Dec 21 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vvishwak...@etouch.net
, Aug 2 2016