New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633538 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 631068
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 635838



Sign in to add a comment

2.7% regression in system_health.memory_desktop at 406503:406513

Project Member Reported by petrcermak@chromium.org, Aug 2 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=633538

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg5rCFqgkM


Bot(s) for this bug's original alert(s):

win-zenbook

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@406502  9797632  168000   8  good
chromium@406513  9732096  135672   8  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 633538

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size_avg/load_social_facebook
Relative Change: 0.54%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/338
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005450670780267024


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6380741470978048

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@406502  9650176  67836.2  8  good
chromium@406532  9764864  70060.9  8  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 633538

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size_avg/load_social_facebook
Relative Change: 1.08%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/358
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005164907982144704


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5797214832558080

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@406467  9666560  92681.9  8  good
chromium@409122  9781248  155679   8  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 633538

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size_avg/load_social_facebook
Relative Change: 0.82%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/366
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004899472146706224


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5259247764373504

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Blockedon: 635838
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 10 2016

Mergedinto: 631068
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove duplication of encoded image data
Author  : hajimehoshi
Commit description:
  
Now there are at least two encoded image data: one is in Image/ImageResource as
SharedBuffer and the other is in DeferredImageDecoder as SkRWBuffer. This CL
removes former when possible (non-icon bitmaps), and generate the SharedBuffer
from the SkRWBuffer if needed.

Design Doc: https://docs.google.com/document/d/1v0yTAZ6wkqX2U_M6BNIGUJpM1s0TIw1VsqpxoL7aciY/edit?usp=sharing

BUG= 618623 
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*:ImageDecoderTest.*

Review-Url: https://codereview.chromium.org/2054643003
Cr-Commit-Position: refs/heads/master@{#406238}
Commit  : 36f4eb81d4a791a8e3dfea4ba2418465d30bcc90
Date    : Tue Jul 19 10:02:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@406231  9358541  71791.1  5  good
chromium@406236  9332326  109663   5  good
chromium@406237  9358541  71791.1  5  good
chromium@406238  9673114  109663   5  bad    <--
chromium@406240  9699328  92681.9  5  bad
chromium@406249  9777971  149445   5  bad
chromium@406267  9725542  109663   5  bad
chromium@406302  9620685  71791.1  5  bad
chromium@406374  9646899  71791.1  5  bad
chromium@406513  9673114  170897   5  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 633538

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size_avg/load_social_facebook
Relative Change: 3.36%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/371
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004807885274352192


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5878829210402816

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment