New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633529 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 633527
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

359.7%-1895.6% regression in system_health.memory_desktop at 406532:408995

Project Member Reported by petrcermak@chromium.org, Aug 2 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@406549  21806350  799.608  12  good
chromium@408985  21806342  818.425  8   bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 633529

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_social-memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/load_social_facebook
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1507
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005450803133899968


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5795818733305856

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 16 2016

Mergedinto: 633527
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactoring: Make member variables in Resource private
Author  : hajimehoshi
Commit description:
  
This CL moves some member variables in Resource class from protected to
private to improve code health.

BUG=n/a
TEST=webkit_unit_tests

Review-Url: https://codereview.chromium.org/2199713002
Cr-Commit-Position: refs/heads/master@{#408943}
Commit  : 33e8546b6e54b2a38d9baa327f45238cf6d64c28
Date    : Mon Aug 01 11:50:46 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@408936  5704499  51681.1  5  good
chromium@408942  5709414  65125.1  5  good
chromium@408943  6149704  36635.7  5  bad    <--
chromium@408944  6125947  53200.7  5  bad
chromium@408946  6129224  54185.0  5  bad
chromium@408958  6125947  44342.9  5  bad

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 633529

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_media-memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/load_media_google_images
Relative Change: 7.39%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/381
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004247583987379488


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5848457667936256

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment