Regression:Weird traces are seen near google page navigation in print preview.
Reported by
adha...@etouch.net,
Aug 2 2016
|
||
Issue descriptionChrome Version:54.0.2816.0 (Official Build)Revision 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090} (32/64-bit) OS:Windows(7,8,10),Mac(10.10.5, 10.11.4),Linux(14.0.4 LTS) Test URL: https://www.google.co.in/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=flowers What steps will reproduce the problem? 1.Launch chrome,navigate to above URL. 2.Press ctrl+p,Ensure 'Background Graphics' option is checked. 3.Scroll till the end of page in print preview,zoom out once and observe. Actual: Weird traces are seen near google page navigation in print preview. Expected: No such traces should be seen near google page navigation in print preview. This is a regression issue, broken in M-51 series, below is bisect info. Good build: 51.0.2686.0 Bad build: 51.0.2687.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/8c912b533f434aa8509495bf0dd6e2dd177d0fce..13317f5288ecf56f51157a52b52b6fb48eed97af?pretty=fuller&n=1000 Skia-roll: https://chromium.googlesource.com/skia.git/+log/ddf9835e9cdf..50e82e61766d?pretty=fuller&n=1000 Review URL: https://codereview.chromium.org/1821533002 Suspecting: r382410? from narrow bisect.
,
Aug 2 2016
,
Sep 30 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/f50ff39f47850b86251b44381983d3b3b4f929b3 commit f50ff39f47850b86251b44381983d3b3b4f929b3 Author: Hal Canary <halcanary@google.com> Date: Fri Sep 30 14:25:39 2016 SkPDF: subset drawImageRect while still deduping - Replace SkImageBitmap with SkImageSubset - SkBitmapKey becomes trivial for simplicity. - SkPDFCanvas::onDraw(Bitmap|Image)Rect now clip and call SkCanvas::onDraw(Bitmap|Image)Rect. - SkPDFDevice::draw(Bitmap|BitmapRect|Sprite) now convert bitmap into SkImageSubset via make_image_subset function. - SkPDFDevice::draw(Image|Bitmap)Rect now implemented again. - SkPDFDevice::internalDrawImage now performs image subsetting as needed, while still deduping properly. BUG= 633528 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2785 Change-Id: I063346d12b0e9c6b6c0c4943ee25400c88aa1a44 Reviewed-on: https://skia-review.googlesource.com/2785 Reviewed-by: Ben Wagner <bungeman@google.com> [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkBitmapKey.h [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFCanvas.cpp [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFDevice.cpp [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFDevice.h [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFShader.cpp
,
Sep 30 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/f50ff39f47850b86251b44381983d3b3b4f929b3 commit f50ff39f47850b86251b44381983d3b3b4f929b3 Author: Hal Canary <halcanary@google.com> Date: Fri Sep 30 14:25:39 2016 SkPDF: subset drawImageRect while still deduping - Replace SkImageBitmap with SkImageSubset - SkBitmapKey becomes trivial for simplicity. - SkPDFCanvas::onDraw(Bitmap|Image)Rect now clip and call SkCanvas::onDraw(Bitmap|Image)Rect. - SkPDFDevice::draw(Bitmap|BitmapRect|Sprite) now convert bitmap into SkImageSubset via make_image_subset function. - SkPDFDevice::draw(Image|Bitmap)Rect now implemented again. - SkPDFDevice::internalDrawImage now performs image subsetting as needed, while still deduping properly. BUG= 633528 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2785 Change-Id: I063346d12b0e9c6b6c0c4943ee25400c88aa1a44 Reviewed-on: https://skia-review.googlesource.com/2785 Reviewed-by: Ben Wagner <bungeman@google.com> [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkBitmapKey.h [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFCanvas.cpp [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFDevice.cpp [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFDevice.h [modify] https://crrev.com/f50ff39f47850b86251b44381983d3b3b4f929b3/src/pdf/SkPDFShader.cpp
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f45dcd15f275cb9393896f9c928f978bf13fa759 commit f45dcd15f275cb9393896f9c928f978bf13fa759 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Fri Sep 30 17:14:51 2016 Roll src/third_party/skia/ 35a02a83f..84741b308 (8 commits). https://chromium.googlesource.com/skia.git/+log/35a02a83f564..84741b308496 $ git log 35a02a83f..84741b308 --date=short --no-merges --format='%ad %ae %s' 2016-09-30 jvanverth Add fence support for TransferBuffers 2016-09-30 mtklein Fix G3 excludes lists for AVX2 -> HSW. 2016-09-30 halcanary SkPDF: subset drawImageRect while still deduping 2016-09-30 mtklein Add an SkOpts target for Haswell+ Intel chips. 2016-09-30 fmalita Revert of Turned on SkSL->GLSL compiler (patchset #41 id:880001 of https://codereview.chromium.org/2288033003/ ) 2016-09-29 bungeman Implement 'action' in gn_to_cmake.py. 2016-09-30 ethannicholas Turned on SkSL->GLSL compiler GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 2016-09-30 fmalita Revert of Fix gamut GM to work w/serialization configs. Remove it from blacklist. (patchset #2 id:20001 of https://codereview.chromium.org/2383513002/ ) BUG= 633528 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=fmalita@google.com Review-Url: https://codereview.chromium.org/2379403002 Cr-Commit-Position: refs/heads/master@{#422137} [modify] https://crrev.com/f45dcd15f275cb9393896f9c928f978bf13fa759/DEPS
,
Oct 4 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tomhud...@chromium.org
, Aug 2 2016Owner: halcanary@chromium.org