New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633514 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

frecon: VT1 does not process image commands

Project Member Reported by dbehr@chromium.org, Aug 2 2016

Issue description

Run frecon in recovery, send image escapes to /dev/pts/0 and they are not processed unless key on the keyboard is pressed. Also, text input on terminal is "delayed" by one character.
 
Is this a regression?  Or has this been happening for a while?
This is not necessarily a regression because previous to kevin the recovery kernel used ply-image to display images.  We see this behavior now because we're trying to port the recovery kernel to frecon.

I have seen this behavior in the recovery kernel on samus and kevin and dbehr has seen it with daisy.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/2b9f123b93537f83e1a4f2d192dcab48a8ba658d

commit 2b9f123b93537f83e1a4f2d192dcab48a8ba658d
Author: Dominik Behr <dbehr@chromium.org>
Date: Tue Aug 02 08:11:12 2016

frecon: fix stdio file descriptors

When frecon runs under busybox based initramfs stdio descriptors do not exist
and epoll and other pts fds created by term alias descriptor numbers 0,1,2.
This change adds a function to create stdio file descriptors using /dev/null
for input and /dev/kmsg for output and uses it to fix stdio descriptiors
of they do not exist. It also reuses this function to create stdio descriptors
for daemon mode since current code using garbage from kmsg for stdin doesn't seem
like a good idea.

BUG= chromium:633514 
TEST=run frecon in recovery

Change-Id: I079f106033c3aa71016d728289b80ceeba09db23
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/365261
Commit-Ready: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/2b9f123b93537f83e1a4f2d192dcab48a8ba658d/util.h
[modify] https://crrev.com/2b9f123b93537f83e1a4f2d192dcab48a8ba658d/util.c
[modify] https://crrev.com/2b9f123b93537f83e1a4f2d192dcab48a8ba658d/main.c

Comment 4 by dbehr@chromium.org, Aug 23 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment