New issue
Advanced search Search tips

Issue 633509 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Aug 2016
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 619452



Sign in to add a comment

Clean up code related to unified text checker

Project Member Reported by xiaoche...@chromium.org, Aug 2 2016 
Unified text checker is always on in Chrome, and can only be off in tests.

We should get rid of this option and clean up the code base accordingly.

Comment 1 by xiaoche...@chromium.org, Aug 9 2016

Description: Show this description

Comment 2 by xiaoche...@chromium.org, Aug 9 2016

Components: UI>Browser>Spellcheck
Labels: OS-All
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fcbc602fb75514f4270b86377009cd787c24222

commit 8fcbc602fb75514f4270b86377009cd787c24222
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 10 05:44:44 2016

Make WebSpellCheckClient aware of leak detection

WebSpellCheckClient stores a set of WebTextCheckingCompletion objects,
which may store references to already invoked SpellCheckRequests. This
patch clears these references before a leak detection so that they will
not become a leak source.

This CL is a preparation for https://codereview.chromium.org/2224103003

BUG= 633509 
TEST=n/a; no visible change

Review-Url: https://codereview.chromium.org/2226833003
Cr-Commit-Position: refs/heads/master@{#410969}

[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/chrome/renderer/spellchecker/spellcheck_provider.cc
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/chrome/renderer/spellchecker/spellcheck_provider.h
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/components/test_runner/spell_check_client.h
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/platform/text/TextCheckerClient.h
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/8fcbc602fb75514f4270b86377009cd787c24222/third_party/WebKit/public/web/WebSpellCheckClient.h
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ada60188def7bc2db291738441ede9262426eaf

commit 3ada60188def7bc2db291738441ede9262426eaf
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 10 11:55:26 2016

Convert some spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG= 633509 

Review-Url: https://codereview.chromium.org/2224103003
Cr-Commit-Position: refs/heads/master@{#411025}

[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word-expected.txt
[modify] https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf/third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html
[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/focusing-other-frame-expected.txt
[modify] https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf/third_party/WebKit/LayoutTests/editing/spelling/focusing-other-frame.html
[modify] https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf/third_party/WebKit/LayoutTests/editing/spelling/resources/util.js
[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt
[modify] https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt
[modify] https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled.html
[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/spelling-insert-html-expected.txt
[delete] https://crrev.com/9c527e632ed763e3cc469b4c11c932f86f7063f1/third_party/WebKit/LayoutTests/editing/spelling/spelling-insert-html.html
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2c22631430d19ef40f61c1d2941e3615cfb90b6

commit d2c22631430d19ef40f61c1d2941e3615cfb90b6
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Aug 12 03:21:17 2016

Convert editing/spelling/grammar-paste.html to use w3c test harness

This patch is a preparation for fixing unified text checker as always
enabled in all tests.

BUG= 633509 
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2230783003
Cr-Commit-Position: refs/heads/master@{#411538}

[delete] https://crrev.com/d566ec668364354078af7c39eeda433f30aef64a/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt
[modify] https://crrev.com/d2c22631430d19ef40f61c1d2941e3615cfb90b6/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html

Comment 6 by xiaoche...@chromium.org, Aug 16 2016 

This is a manual note that revisions r412164 and r412166 refer to this bug.

I entered the wrong bug numbers in their commit messages...
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c834c701596ce195884a13dd64101c5aa26e087

commit 1c834c701596ce195884a13dd64101c5aa26e087
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Aug 16 05:43:08 2016

Auto-rebaseline for r412164

https://chromium.googlesource.com/chromium/src/+/accb28ab5

BUG= 633509 
TBR=xiaochengh@chromium.org

Review URL: https://codereview.chromium.org/2253493002 .

Cr-Commit-Position: refs/heads/master@{#412173}

[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/fast/dom/blur-contenteditable-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/fast/inline-block/14498-positionForCoordinates-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/fast/repaint/inline-outline-repaint-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux-precise/fast/inline-block/14498-positionForCoordinates-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux-precise/fast/inline-block/14498-positionForCoordinates-expected.txt
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-retina/fast/inline-block/14498-positionForCoordinates-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac-retina/fast/inline-block/14498-positionForCoordinates-expected.txt
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/inline-block/14498-positionForCoordinates-expected.txt
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win7/fast/inline-block/14498-positionForCoordinates-expected.png
[add] https://crrev.com/1c834c701596ce195884a13dd64101c5aa26e087/third_party/WebKit/LayoutTests/platform/win7/fast/inline-block/14498-positionForCoordinates-expected.txt

Comment 8 by xiaoche...@chromium.org, Aug 17 2016

Status: Fixed (was: Assigned)

Comment 9 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment