Chrome UI needs to show correct icon when speaker line-out is plugged |
|||||||||
Issue descriptionWe have a new codec can detect the plugged jack is for headphone or speaker line-out, and this info will pass up from CRAS to Chrome. In chromeos/audio/audio_device.cc, AudioDevice::GetAudioType() will see CRAS report this node type using string "LINE_OUT". I'd be great Chrome UI can treat this type of node differently than 'Headphone', for example: - default node volume - default node priority - node icon https://goo.gl/9sao3V Jenny: can you help with this task?
,
Aug 5 2016
hychao@, I can certainly help this in chrome UI code. We need to loop in PM for this feature too. The following detail will need to be figured out: 1. We will need cras to assign a different node id and stable device id to line-out and headphone. Otherwise, these two device's state and settings can be mixed up. 2. What kind of priority the line-out should have, will be it the same as headphone? 3. We will need an icon from designer for line-out to display in the ash tray.
,
Aug 8 2016
CRAS side change at: https://chromium-review.googlesource.com/#/c/363663/5 audio/audio_device change at: https://codereview.chromium.org/2222903002/ with above two CLs, Chrome UI can get the line-out node type reported by CRAS. I think line-out node should have the same priority and default volume as 'headphone' node. We will let partner configure separate volume curve for line-out audio device.
,
Aug 15 2016
kuscher@, I have LGTMed hychao's cl for the adding the line-out output device type. Once it lands, I can finish the UI code to expose the device in UI. We will need to add a new icon this the line-out speaker. Can you find someone to help us?
,
Aug 15 2016
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a8395b5715c5dc4d0e84353e814f5a08cd29742 commit 4a8395b5715c5dc4d0e84353e814f5a08cd29742 Author: hychao <hychao@chromium.org> Date: Tue Aug 16 03:30:12 2016 audio_device: Add lineout node type BUG=633467 R=jennyz@chromium.org Review-Url: https://codereview.chromium.org/2222903002 Cr-Commit-Position: refs/heads/master@{#412158} [modify] https://crrev.com/4a8395b5715c5dc4d0e84353e814f5a08cd29742/chromeos/audio/audio_device.cc [modify] https://crrev.com/4a8395b5715c5dc4d0e84353e814f5a08cd29742/chromeos/audio/audio_device.h
,
Aug 31 2016
We have device supporting line-out using M54 as FSI.
,
Aug 31 2016
kuscher@, can you fine someone to make a new icon for the line-out device?
,
Aug 31 2016
54 has already branched. I'm not convinced that showing the "correct" icon when a line out device is connected justifies a merge. By the time we get an icon created and agree on it, it would likely be a fairly late merge. If someone feels strongly we can discuss, but I'm punting this to 55.
,
Nov 11 2016
We have device with lineout support in M56. Can we target this feature at M56?
,
Nov 11 2016
56 is already in feature freeze and it looks like we don't have assets for this yet.
,
Jan 17 2017
@sgabriel could you share a line out icon? Some examples here: https://en.wikipedia.org/wiki/Line_level#Line_out
,
Jan 17 2017
We already have a line-out icon that are used in the sub-panel. I attached they assets. Would that work?
,
Jan 19 2017
Given we're so close to m-56 stable, any further changes here should almost certainly not be targeted at m-56. Punting to m-58. tbuckley@, please re-triage if you disagree.
,
Feb 21 2017
jennyz@ friendly ping - just curious about the status of this issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hychao@chromium.org
, Aug 2 2016