New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633467 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Chrome UI needs to show correct icon when speaker line-out is plugged

Project Member Reported by hychao@chromium.org, Aug 2 2016

Issue description

We have a new codec can detect the plugged jack is for headphone or speaker line-out, and this info will pass up from CRAS to Chrome.

In chromeos/audio/audio_device.cc, AudioDevice::GetAudioType() will see CRAS report this node type using string "LINE_OUT".

I'd be great  Chrome UI can treat this type of node differently than 'Headphone', for example:
- default node volume
- default node priority
- node icon https://goo.gl/9sao3V

Jenny: can you help with this task?

 
Background of this feature request in http://crosbug.com/p/55239
Cc: abodenha@chromium.org kuscher@chromium.org
Components: UI>Shell>StatusArea
Labels: OS-Chrome
hychao@, I can certainly help this in chrome UI code. We need to loop in PM for this feature too. The following detail will need to be figured out:
1. We will need cras to assign a different node id and stable device id to line-out and headphone. Otherwise, these two device's state and settings can be mixed up.
2. What kind of priority the line-out should have, will be it the same as headphone?
3. We will need an icon from designer for line-out to display in the ash tray.

CRAS side change at: https://chromium-review.googlesource.com/#/c/363663/5
audio/audio_device change at: https://codereview.chromium.org/2222903002/

with above two CLs, Chrome UI can get the line-out node type reported by CRAS.
I think line-out node should have the same priority and default volume as 'headphone' node. We will let partner configure separate volume curve for line-out audio device.

Comment 4 by jen...@chromium.org, Aug 15 2016

kuscher@, I have LGTMed hychao's cl for the adding the line-out output device type. Once it lands, I can finish the UI code to expose the device in UI. We will need to add a new icon this the line-out speaker. Can you find someone to help us?

Comment 5 by jen...@chromium.org, Aug 15 2016

Status: Started (was: Available)

Comment 7 by hychao@chromium.org, Aug 31 2016

Labels: M-54
We have device supporting line-out using M54 as FSI.

Comment 8 by jen...@chromium.org, Aug 31 2016

kuscher@, can you fine someone to make a new icon for the line-out device?
Labels: -M-54 M-55
54 has already branched.  I'm not convinced that showing the "correct" icon when a line out device is connected justifies a merge.  By the time we get an icon created and agree on it, it would likely be a fairly late merge.

If someone feels strongly we can discuss, but I'm punting this to 55.
Labels: -M-55 M-56
We have device with lineout support in M56. Can we target this feature at M56?
56 is already in feature freeze and it looks like we don't have assets for this yet.
Cc: tbuck...@chromium.org jen...@chromium.org
Owner: sgabr...@chromium.org
@sgabriel could you share a line out icon? Some examples here: https://en.wikipedia.org/wiki/Line_level#Line_out
Owner: jen...@chromium.org
We already have a line-out icon that are used in the sub-panel. I attached they assets. Would that work?
output.zip
1.5 KB Download
Labels: -M-56 Proj-MaterialDesign-CrOS M-58
Given we're so close to m-56 stable, any further changes here should almost certainly not be targeted at m-56. Punting to m-58. tbuckley@, please re-triage if you disagree.
jennyz@ friendly ping - just curious about the status of this issue.

Sign in to add a comment