Add power management settings |
|||||||||||||||||
Issue descriptionWe should expose some general power-management settings (namely, idle behavior as exposed via chrome.power.requestKeepAwake and lid-closed behavior) in the "power" section of the Device settings page. I wrote a proposal that no one seems to hate. I'll take a look at this after the power section is implemented for Material Design (device settings are tracked at issue 546834 ).
,
Aug 2 2016
,
Aug 5 2016
,
Sep 23 2016
,
Sep 23 2016
,
Oct 21 2016
,
Dec 6 2016
,
Feb 13 2017
We'll probably also need to promote the existing power settings from a single row to a dedicated subpage for this.
,
Feb 15 2017
If/when we create a subpage for power, we should redirect chrome::kPowerSubPage to settings/power instead of settings/device.
,
Feb 15 2017
(See notes in issue 692334 for the above comment)
,
Feb 17 2017
,
Feb 20 2017
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f2dc13d423abd8414e6bd5624aa516fcb1e683d commit 8f2dc13d423abd8414e6bd5624aa516fcb1e683d Author: derat <derat@chromium.org> Date: Thu Mar 02 01:34:32 2017 chromeos: Add Power device page to chrome://md-settings. Move the power row into its own subpage in anticipation of adding additional settings. BUG= 633484 , 633455 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2629573006 Cr-Commit-Position: refs/heads/master@{#454136} [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/app/settings_strings.grdp [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/device_page/device_page.html [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/device_page/device_page.js [add] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/device_page/power.html [add] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/device_page/power.js [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/route.js [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/8f2dc13d423abd8414e6bd5624aa516fcb1e683d/chrome/test/data/webui/settings/device_page_tests.js
,
Mar 20 2017
Issue 227206 has been merged into this issue.
,
Apr 22 2017
With MD Settings enabled, Ash notifications still route to chrome://settings/device, not chrome://settings/power. Fix here: https://codereview.chromium.org/2835023002/ Worth merging into 59?
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be955b43265817336cd940d144cd05a0e1c8495a commit be955b43265817336cd940d144cd05a0e1c8495a Author: michaelpg <michaelpg@chromium.org> Date: Mon Apr 24 20:04:34 2017 Remove obsolete chrome://settings/power redirect for MD Settings chrome://settings/power in MD Settings now exists as a subpage, as in old Options, so allow navigation there instead of redirecting to the top-level Device section. A click on a USB dual-role notification will now open the Power subpage directly. BUG= 633455 Review-Url: https://codereview.chromium.org/2835023002 Cr-Commit-Position: refs/heads/master@{#466726} [modify] https://crrev.com/be955b43265817336cd940d144cd05a0e1c8495a/chrome/browser/ui/chrome_pages.cc
,
Apr 24 2017
This is a small change that allows the USB dual-role charger notification to open the MD Settings Power page directly, instead of just opening MD Settings. This worked in the old Options page, but we forgot to remove an exception for MD Settings that is no longer necessary.
,
Apr 25 2017
This bug requires manual review: There is .grd file changes and we are only 41 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
Re #18: The .grd changes were long ago. The merge request to 59 is just for the tiny bugfix at https://codereview.chromium.org/2835023002. The overall feature request is still open and won't be going in for 59.
,
May 2 2017
Cc-ing gkihumba@ for review for merge to 59.
,
May 5 2017
,
May 15 2017
Issue 302101 has been merged into this issue.
,
May 24 2017
,
Jun 20 2017
,
Jun 20 2017
,
Jun 23 2017
I'm making a few minor UI tweaks as discussed at https://goto.google.com/nhjjn.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7271d8176c0ad892bab3b2415f6dcace6a87a0b3 commit 7271d8176c0ad892bab3b2415f6dcace6a87a0b3 Author: Daniel Erat <derat@chromium.org> Date: Fri Jun 23 22:41:49 2017 chromeos: Rename "Turn off display" power idle setting. Per discussion with UX, rename the "Turn off display but stay awake" power management idle setting to "Turn off display". Also rename associated constants. BUG= 633455 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ab405a7d13915f04295199c5065d9ca47372148 Reviewed-on: https://chromium-review.googlesource.com/545202 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#482053} [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/app/settings_strings.grdp [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/resources/settings/device_page/power.js [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/ui/webui/settings/chromeos/device_power_handler.h [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/ui/webui/settings/chromeos/device_power_handler_unittest.cc [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/7271d8176c0ad892bab3b2415f6dcace6a87a0b3/chrome/test/data/webui/settings/device_page_tests.js
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91e2d1a791aada23704d812f40f6a29421cdb434 commit 91e2d1a791aada23704d812f40f6a29421cdb434 Author: Daniel Erat <derat@chromium.org> Date: Wed Jun 28 00:34:39 2017 chromeos: Change lid-closed power setting to checkbox. Per UX discussion, change Chrome OS's lid-closed behavior power management setting to be a checkbox/toggle rather than a <select>-based dropdown menu. If the underlying pref is unmanaged, the checkbox is labeled "Sleep when lid is closed", and the checked and unchecked states represent the (default) "suspend" and "do nothing" behaviors. If the underlying pref is managed, the label can change to "Shut down when lid is closed" or "Sign out when lid is closed" when the corresponding behavior has been configured. BUG= 633455 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a8654429d4a7a0bfd0ff81f98219aaee3621a56 Reviewed-on: https://chromium-review.googlesource.com/547052 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#482819} [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/app/settings_strings.grdp [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/browser/resources/settings/device_page/power.html [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/browser/resources/settings/device_page/power.js [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/91e2d1a791aada23704d812f40f6a29421cdb434/chrome/test/data/webui/settings/device_page_tests.js
,
Jun 28 2017
,
Sep 19 2017
Issue 287071 has been merged into this issue.
,
Sep 19 2017
,
Jan 22 2018
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by tbuck...@chromium.org
, Aug 2 2016