New issue
Advanced search Search tips

Issue 633437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ShelfLayoutManager changes work area in non-sticky mode

Project Member Reported by hariank@google.com, Aug 2 2016

Issue description

Currently OnKeyboardBoundsChanging in ShelfLayoutManager changes the work area of the screen, which causes windows to resize when the keyboard is toggled. With the new virtual keyboard behavior, this should only happen in sticky (locked) mode and not in non-sticky mode. 


 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 5 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3dbde950da912fb78154beff5ea827a6e8cf5dd

commit b3dbde950da912fb78154beff5ea827a6e8cf5dd
Author: hariank <hariank@google.com>
Date: Thu Aug 11 22:06:26 2016

ShelfLayoutManager virtual keyboard - do not change work area of screen if in non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG= 633437 

Review-Url: https://codereview.chromium.org/2200963002
Cr-Commit-Position: refs/heads/master@{#411427}

[modify] https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd/ash/shelf/shelf_layout_manager_unittest.cc

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
This owner is not able to receive e-mails, please re-triage.
Status: Fixed (was: Untriaged)

Sign in to add a comment