New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633431 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ec: Remove NOR flash write protect ranges that we don't care about

Reported by dhend...@chromium.org, Aug 2 2016

Issue description

The purpose of this bug is to clarify the definition of the write-protection tables currently in ec/common/spi_flash_reg.c.

As the comment in spi_flash_reg suggests, it's really not necessary to define all ranges in the datasheet since we basically only care about protecting a few ranges: none, half, or maybe a quarter in some cases. And, since CrOS ECs all boot from the lower portion of the address space (someone plz yell if I'm wrong) we only care about protecting the lower fractions of the address space.

There might be multiple ranges with the same result, particularly if a CMP bit is present. Since the range might be set by some other program (OEM software or flashrom) it's still necessary to cover all permutations of the ranges that we care about.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/fdcec72d1ac5591e4a5335e9fc1671e19e6651ac

commit fdcec72d1ac5591e4a5335e9fc1671e19e6651ac
Author: David Hendricks <dhendrix@chromium.org>
Date: Tue Aug 02 00:59:48 2016

spi_flash: Remove unused write-protect ranges

This removes write-protect ranges that are unnecessary so
that we save a bit of space.

BUG= chromium:633431 
BRANCH=none
TEST=compiled only.

Change-Id: Ib34c6a125b001fc92a21f795ac3d922e77143342
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/365210
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/fdcec72d1ac5591e4a5335e9fc1671e19e6651ac/common/spi_flash_reg.c

Status: Fixed (was: Started)

Sign in to add a comment