New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633421 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
(currently inactive on Chromium)
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

ScrollAnchorTest.OptOutScrollingDiv failing on WebKit Android (Nexus4)

Project Member Reported by ssid@chromium.org, Aug 2 2016

Issue description

First failed build:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/51256

Error message:
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  [ RUN      ] ScrollAnchorTest.OptOutScrollingDiv
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:635: Failure
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Value of: scroller->scrollPosition().y()
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)    Actual: 300
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Expected: 100
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:636: Failure
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Value of: scrollAnchor(scroller).anchorObject()
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)    Actual: 0x7901c1d4
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Expected: nullptr
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Which is: NULL

Suspected CL:
Change #9232

Changed by	bauerb@chromium.org
Changed at	Sun 31 Jul 2016 08:24:54
Repository	https://chromium.googlesource.com/chromium/src
Project	chromium
Branch	master
Revision	7a676cfc5291809bf2a95fd16ba1d57907f7961a
Comments

Use only toolbar to transition from fakebox to real omnibox.

Previously, we would fade out the fakebox and fade in the real omnibox during
the scroll transition, which created discrepancies. With this change, the
toolbar omnibox does the full transition. The search box on the NTP is still
kept, both to get the starting point of the transition, and for the tablet
toolbar, where the omnibox stays at the top, so there are two boxes.

Because the two boxes now have to match, their dimensions and padding 
...skip...
ble -- it was the same as |textbox|, but with
  a margin added at the top and bottom (but *not* left or right). Since we
  calculate the omnibox bounds manually anyway, this allows us to account for
  the omnibox padding in the same way in either dimension.
* Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
  the member variable.

BUG= 605054 , 625108 , 618955 ,616728,612520

Review-Url: https://codereview.chromium.org/2134663002
 
Owner: ymalik@chromium.org
+ymalik

Not really familiar with the blink code at all, but this test you wrote is failing on some of the Android bots.
Hoping you might know what the problem is.

I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:635: Failure
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Value of: scroller->scrollPosition().y()
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)    Actual: 300
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Expected: 100
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:636: Failure
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Value of: scrollAnchor(scroller).anchorObject()
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)    Actual: 0x7901c1d4
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Expected: nullptr
I  142.639s run_tests_on_device(01c9f6601f1ea6b6)  Which is: NULL
Status: Available (was: Untriaged)

Comment 3 by ymalik@chromium.org, Nov 14 2016

Cc: skobes@chromium.org
That link is not working for me. 

Is this test still failing?

Comment 4 by skobes@chromium.org, Nov 14 2016

Status: WontFix (was: Available)
This test hasn't failed in the last 200 runs of that bot:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=200

So I suggest closing this as not reproducible.

Sign in to add a comment