First failed build:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/51256
Error message:
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) [ RUN ] ScrollAnchorTest.OptOutScrollingDiv
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:635: Failure
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Value of: scroller->scrollPosition().y()
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Actual: 300
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Expected: 100
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) ../../third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:636: Failure
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Value of: scrollAnchor(scroller).anchorObject()
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Actual: 0x7901c1d4
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Expected: nullptr
I 142.639s run_tests_on_device(01c9f6601f1ea6b6) Which is: NULL
Suspected CL:
Change #9232
Changed by bauerb@chromium.org
Changed at Sun 31 Jul 2016 08:24:54
Repository https://chromium.googlesource.com/chromium/src
Project chromium
Branch master
Revision 7a676cfc5291809bf2a95fd16ba1d57907f7961a
Comments
Use only toolbar to transition from fakebox to real omnibox.
Previously, we would fade out the fakebox and fade in the real omnibox during
the scroll transition, which created discrepancies. With this change, the
toolbar omnibox does the full transition. The search box on the NTP is still
kept, both to get the starting point of the transition, and for the tablet
toolbar, where the omnibox stays at the top, so there are two boxes.
Because the two boxes now have to match, their dimensions and padding
...skip...
ble -- it was the same as |textbox|, but with
a margin added at the top and bottom (but *not* left or right). Since we
calculate the omnibox bounds manually anyway, this allows us to account for
the omnibox padding in the same way in either dimension.
* Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
the member variable.
BUG= 605054 , 625108 , 618955 ,616728,612520
Review-Url: https://codereview.chromium.org/2134663002
Comment 1 by mikec...@chromium.org
, Aug 4 2016