New issue
Advanced search Search tips

Issue 633407 link

Starred by 2 users
Status: Fixed
Owner:
donnd@chromium.org
Closed: Oct 2016
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[TTS] Update test configuration to support M-53 experiments

Project Member Reported by donnd@chromium.org, Aug 1 2016 
We need to update the test configuration for Contextual Search on Android to test M-53 experiments.
We need to enable experiments for scroll-suppression, tap-suppression, and quick answers.
This should have been done for M-52 for scroll-suppression and quick answers.
Support for translation turns out to be non-trivial because the mocking test infrastructure needs another mock for translation.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9784b5a19baf40450cb710d752b688f1fb9feef

commit a9784b5a19baf40450cb710d752b688f1fb9feef
Author: donnd <donnd@chromium.org>
Date: Tue Aug 02 23:12:25 2016

[TTS] Update the Tap Event Test to support Translations.

Updates our mock-test infrastructure in ContextualSearchTapEventTest to
have a new mock for the ContextualSearchTranslateController that mocks
calls to the native ContextualSearchManager (which does not exist in the
mock environment).

This allows enabling translation in our waterfall tests.
Still TODO -- adding more tests for Translation.

BUG= 633407 

Review-Url: https://codereview.chromium.org/2206613002
Cr-Commit-Position: refs/heads/master@{#409372}

[modify] https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTranslateController.java
[modify] https://crrev.com/a9784b5a19baf40450cb710d752b688f1fb9feef/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6a1d0f36d226d6cd67072f0d787043ed66be252

commit c6a1d0f36d226d6cd67072f0d787043ed66be252
Author: donnd <donnd@chromium.org>
Date: Wed Aug 03 16:35:21 2016

[TTS] Update instrumentation tests to work with Tap Suppression.

At least one instrumentation test fails due to Tap Suppression.
This CL disables suppression for the existing failing test so we will test old behavior.
Also remove an obsolete testing flage (since TTS is now default-on).

Still TODO add new tests for suppression.

BUG= 633407 

Review-Url: https://codereview.chromium.org/2204983002
Cr-Commit-Position: refs/heads/master@{#409533}

[modify] https://crrev.com/c6a1d0f36d226d6cd67072f0d787043ed66be252/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/c6a1d0f36d226d6cd67072f0d787043ed66be252/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/c6a1d0f36d226d6cd67072f0d787043ed66be252/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 3 by donnd@chromium.org, Oct 6 2016

Status: Fixed (was: Started)
►

Sign in to add a comment