CursorAnchorInfoControllerTest testMonitorMode failing in Lollipop bots |
||||||||
Issue descriptionFirst failed builds: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5981 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/3750 Error message: I 144.995s run_tests_on_device(06ad8d5c003b6dd5) junit.framework.AssertionFailedError: expected:<1> but was:<2> I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at org.chromium.content.browser.input.CursorAnchorInfoControllerTest.testMonitorMode(CursorAnchorInfoControllerTest.java:315) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 144.995s run_tests_on_device(06ad8d5c003b6dd5) INSTRUMENTATION_STATUS: test=testMonitorMode I 144.995s run_tests_on_device(06ad8d5c003b6dd5) INSTRUMENTATION_STATUS: class=org.chromium.content.browser.input.CursorAnchorInfoControllerTest I 144.995s run_tests_on_device(06ad8d5c003b6dd5) INSTRUMENTATION_STATUS: stack=junit.framework.AssertionFailedError: expected:<1> but was:<2> I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at org.chromium.content.browser.input.CursorAnchorInfoControllerTest.testMonitorMode(CursorAnchorInfoControllerTest.java:315) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) I 144.995s run_tests_on_device(06ad8d5c003b6dd5) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) I 144.996s run_tests_on_device(06ad8d5c003b6dd5) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) Suspected CL: Changed by nona@chromium.org Changed at Sun 31 Jul 2016 19:33:02 Repository https://chromium.googlesource.com/chromium/src Project src Branch master Revision dac0c7af14c29c9d8509b775d5044e5448b6263b Comments Do not calculate composition bounds until IME requests. Calculating composition bounds is not a light-weight operation. On the other hand, few IME uses this information. To skip this unnecessary calculation on certain environment, propagate cursor update mode from browser to the renderer. BUG= 624714 Review-Url: https://codereview.chromium.org/2121953002 Cr-Commit-Position: refs/heads/master@{#408900}
,
Aug 4 2016
,
Aug 4 2016
Pinging this bug. This test is still failing on the Lollipop bots.
,
Aug 4 2016
,
Aug 4 2016
I've been seeing this fail in trybots a lot. This test seems very flaky now. I don't think this is necessarily just a test problem, I suspect testMonitorMode is actually broken in a racy manner.
,
Aug 4 2016
,
Aug 4 2016
,
Aug 4 2016
Hmm, I see it's not flaky, it's 100% broken. I'll revert the change.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b24cbc456753503ec0f499c890acae6a5a2e3cc3 commit b24cbc456753503ec0f499c890acae6a5a2e3cc3 Author: aelias <aelias@chromium.org> Date: Thu Aug 04 21:15:24 2016 Revert of Do not calculate composition bounds until IME requests. (patchset #11 id:720001 of https://codereview.chromium.org/2121953002/ ) Reason for revert: CursorAnchorInfoControllerTest.testMonitorMode consistently failing on downstream lollipop bots (and I also see the same failure in the trybots for patchset 11, I don't understand why CQ let this through...). BUG= 633402 Original issue's description: > Do not calculate composition bounds until IME requests. > > Calculating composition bounds is not a light-weight operation. > On the other hand, few IME uses this information. > To skip this unnecessary calculation on certain environment, propagate > cursor update mode from browser to the renderer. > > BUG= 624714 > > Committed: https://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b > Cr-Commit-Position: refs/heads/master@{#408900} TBR=changwan@chromium.org,kinaba@chromium.org,shuchen@chromium.org,yosin@chromium.org,yukawa@chromium.org,nasko@chromium.org,nona@chromium.org NOTRY=true BUG= 624714 Review-Url: https://codereview.chromium.org/2210533004 Cr-Commit-Position: refs/heads/master@{#409901} [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/browser/renderer_host/ime_adapter_android.cc [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/browser/renderer_host/ime_adapter_android.h [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/common/input_messages.h [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/public/android/javatests/src/org/chromium/content/browser/input/CursorAnchorInfoControllerTest.java [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/renderer/render_frame_impl.cc [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/renderer/render_widget.cc [modify] https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3/content/renderer/render_widget.h
,
Aug 4 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dgn@chromium.org
, Aug 3 2016