New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633401 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK in DefaultPlatformDisplay when pressing ctrl-alt-m

Project Member Reported by sky@chromium.org, Aug 1 2016

Issue description

Here's the trace:

[12577:12577:0801/110458:10411992822:FATAL:platform_display.cc(225)] Check failed: key_press_event->GetCharacter() == char_event.GetCharacter() (13 vs. 10)
#0 0x7f89adf9f07e base::debug::StackTrace::StackTrace()
#1 0x7f89adffaa4c logging::LogMessage::~LogMessage()
#2 0x7f89b448b4c8 ui::ws::DefaultPlatformDisplay::DispatchEvent()
#3 0x7f899a458d59 _ZN4base8internal13FunctorTraitsIMN2ui22PlatformWindowDelegateEFvPNS2_5EventEEvE6InvokeIPS3_JS5_EEEvS7_OT_DpOT0_
#4 0x7f899a458c96 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2ui22PlatformWindowDelegateEFvPNS4_5EventEEJPS5_S7_EEEvOT_DpOT0_
#5 0x7f899a458c27 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE7RunImplIRKS8_RKSt5tupleIJSA_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS6_
#6 0x7f899a458a1c _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE3RunEPNS0_13BindStateBaseEOS6_
#7 0x7f89a2402ed6 base::Callback<>::Run()
#8 0x7f89a2402caa ui::DispatchEventFromNativeUiEvent()
#9 0x7f899a4582f7 ui::X11WindowOzone::DispatchEvent()
#10 0x7f89ae40ebbf ui::PlatformEventSource::DispatchEvent()
#11 0x7f899a4c5cbb ui::X11EventSourceLibevent::ProcessXEvent()
#12 0x7f899a4b8cca ui::X11EventSource::ExtractCookieDataDispatchEvent()
#13 0x7f899a4b8c01 ui::X11EventSource::DispatchXEvents()
#14 0x7f899a4c61ff ui::X11EventSourceLibevent::OnFileCanReadWithoutBlocking()
#15 0x7f89ae02ceb1 base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking()
#16 0x7f89ae02e1cf base::MessagePumpLibevent::OnLibeventNotification()
#17 0x7f89ae22a5de event_process_active
#18 0x7f89ae229c27 event_base_loop
#19 0x7f89ae02e4a0 base::MessagePumpLibevent::Run()
#20 0x7f89ae016eea base::MessageLoop::RunHandler()
#21 0x7f89ae0ae5a4 base::RunLoop::Run()
#22 0x7f89ae016091 base::MessageLoop::Run()
#23 0x7f89aecd7cdb MashRunner::StartChildApp()

Assigning to erg@ as it looks like he added the DCHECK here: https://codereview.chromium.org/1234623004
 

Comment 1 by sky@chromium.org, Aug 1 2016

Cc: jamescook@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/663728cb129b3ce5740a9b31adc9a190e283e903

commit 663728cb129b3ce5740a9b31adc9a190e283e903
Author: erg <erg@chromium.org>
Date: Tue Aug 02 22:57:07 2016

mus: Remove DCHECK that was causing false positives.

When translating from a key event to a character event, it's valid to
have the character change, ie, from 'M' to '^M'.

BUG= 633401 

Review-Url: https://codereview.chromium.org/2203953002
Cr-Commit-Position: refs/heads/master@{#409368}

[modify] https://crrev.com/663728cb129b3ce5740a9b31adc9a190e283e903/services/ui/ws/platform_display.cc

Comment 3 by e...@chromium.org, Aug 2 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment