[Windows][Host] Update MSI build files to handle debug component builds. |
|||
Issue descriptionPer chromium dev discussion (https://groups.google.com/a/chromium.org/d/topic/chromium-dev/LWRR3fMlvQ4/discussion), we will need to decide whether to update our installer to work correctly in component builds or turn off MSI generation in debug builds. My preference is to allow Debug MSIs as long as the logic doesn't deviate too far from our non-component release builds (i.e. if it becomes too convoluted we can just prevent MSI generation). Marking P3 for now, we can raise the priority when/if a global build change becomes imminent.
,
Aug 3 2016
I do not think this can be marked as difficult. Ideally we only need to add several dll files into our packages when is_component == true.
,
Aug 8 2016
Bumping the priority. This build change was made on Aug 3rd (commit 5e90548f18cc7ce931c3fda659ebad2ebb9bc3f0) so our MSI packages are now broken on debug builds. I tried setting is_component_build to false on my debug build and the package was still not built correctly (assuming that flag was overridden in another build file) so fixing this bug is now more important.
,
Aug 15 2016
Talked offline with Joe, we will disable component builds for MSI file now.
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7cf182958b7d85352fec709fc823956032bab3c commit f7cf182958b7d85352fec709fc823956032bab3c Author: zijiehe <zijiehe@chromium.org> Date: Tue Aug 16 00:20:28 2016 [Chromoting] Disable remoting_host_installation in component build Dll dependencies are hard to maintain, so we disable remoting_host_installation in component build. BUG= 633368 Review-Url: https://codereview.chromium.org/2245253002 Cr-Commit-Position: refs/heads/master@{#412110} [modify] https://crrev.com/f7cf182958b7d85352fec709fc823956032bab3c/remoting/host/BUILD.gn
,
Aug 16 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jamiewa...@chromium.org
, Aug 2 2016Status: Assigned (was: Untriaged)