MD Settings: blank dialog stuck open on Chrome OS |
|||||||
Issue descriptionIn ToT, visiting chrome://md-settings/advanced on Chrome OS on Linux shows a blank dialog overlaid on the Bluetooth section. Inspector shows it's the bluetooth-device-dialog. The dialog has an "x" button and a grey line. The "x" button triggers: "Uncaught InvalidStateError: Failed to execute 'close' on 'HTMLDialogElement': The element does not have an 'open' attribute, and therefore cannot be closed.", source: chrome://resources/cr_elements/cr_dialog/cr_dialog.js (20)
,
Aug 1 2016
,
Aug 1 2016
,
Aug 1 2016
Found the problem, but not the fix yet. It is a CSS specificity issue (see attachement). The dialog should have display:none because of the "dialog:not([open])" CSS selector, but the "html /deep/ ..." selector is applying display: flex instead.
,
Aug 1 2016
I am guessing that is because of this html:
<dialog is="cr-dialog" id="dialog" class="layout vertical"
on-cancel="onDialogCanceled_">
I can insert an inner div instead. I didn't think that 'display' might be used to hide the dialog.
,
Aug 1 2016
Actually, an inner div isn't needed, the layout is leftover from the pre cr-dialog implementation. The fix is trivial.
,
Aug 1 2016
Fix is here: https://codereview.chromium.org/2202023003/
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51163149b8acd7e0519dba287946a480a92df844 commit 51163149b8acd7e0519dba287946a480a92df844 Author: dpapad <dpapad@chromium.org> Date: Tue Aug 02 00:40:12 2016 MD Settings: Restore display: none for Bluetooth dialog. BUG= 633367 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2205683002 Cr-Commit-Position: refs/heads/master@{#409104} [modify] https://crrev.com/51163149b8acd7e0519dba287946a480a92df844/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
,
Aug 2 2016
,
Aug 29 2016
,
Oct 7 2016
,
Oct 20 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20 No blank dialog is seen on Bluetooth section |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Aug 1 2016