New issue
Advanced search Search tips

Issue 633358 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cache API should not match() HEAD requests

Project Member Reported by jsb...@chromium.org, Aug 1 2016

Issue description

I believe this spec change renders  issue 476815  obsolete
Owner: jsb...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e

commit b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e
Author: jsbell <jsbell@chromium.org>
Date: Wed Aug 10 22:47:27 2016

Cache API should not match() HEAD requests

Per spec issue, the match()/matchAll() methods should not match HEAD
requests, yielding undefined (or an empty result set).

[1] https://github.com/slightlyoff/ServiceWorker/issues/710#issuecomment-236641802

BUG= 633358 

Review-Url: https://codereview.chromium.org/2204683002
Cr-Commit-Position: refs/heads/master@{#411172}

[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-delete.js
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js
[delete] https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-match-expected.txt
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-matchAll-expected.txt
[add] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-keys.html
[delete] https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt
[add] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-keys.html
[delete] https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-match-expected.txt
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/b482718f3ced3088afbd8bfdd7ff51fdfdc9bc8e/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

Comment 4 by jsb...@chromium.org, Aug 11 2016

Status: Fixed (was: Started)

Sign in to add a comment