New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633341 link

Starred by 2 users
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
asanka@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
EnamelAndFriendsFixIt


Sign in to add a comment

PPAPIDownloadRequest.RequestDuration is always 0

Project Member Reported by nparker@chromium.org, Aug 1 2016 
Some concerning metrics: https://uma.googleplex.com/p/chrome/histograms/?endDate=07-31-2016&dayCount=7&histograms=SBClientDownload.PPAPIDownloadRequest.RequestOutcome%2CSBClientDownload.PPAPIDownloadRequest.Result&fixupData=true&showMax=true&filters=milestone%2Cge%2C52%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

SBClientDownload.PPAPIDownloadRequest.RequestOutcome shows
  Response was malformed: 3.5%
  Succeeded: 1.2%

That means we're failing more than we're succeeding. Also, SBClientDownload.PPAPIDownloadRequest.RequestDuration doesn't look right -- It's always 0.

Comment 1 by nparker@chromium.org, Aug 1 2016

Labels: -Pri-1 Pri-2
Summary: PPAPIDownloadRequest.RequestDuration is always 0 (was: Flash-download protection has high malformed-response rate)
oops, nevermind on the malformed requests.  That was due to the proto change, and it actually represents the UNKNOWN verdicts for < M53. Those go away in M53.

Comment 2 by vakh@chromium.org, Mar 10 2017

Cc: asanka@chromium.org
Labels: -Pri-2 Hotlist-GoodFirstBug Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 3 by jialiul@chromium.org, Apr 7 2017

Owner: jialiul@chromium.org
Status: Assigned (was: Available)

Comment 4 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c92925133d1cd4f8d98163adac0119feb90e1f5

commit 6c92925133d1cd4f8d98163adac0119feb90e1f5
Author: Jialiu Lin <jialiul@chromium.org>
Date: Sat Nov 18 01:13:24 2017

Fix PPAPIDownloadRequest.RequestDuration metric

PPAPIDownloadRequest.RequestDuration is always zero. This is because
UMA_HISTOGRAM_TIMES macro cannot handle negative number. This Cl fixes
this issue.

Bug:  633341 
Change-Id: I8dd1200ed7f28e746469b4d82ef0e927a5080a88
Reviewed-on: https://chromium-review.googlesource.com/777887
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517657}
[modify] https://crrev.com/6c92925133d1cd4f8d98163adac0119feb90e1f5/chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc

Comment 6 by jialiul@chromium.org, Nov 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment