New issue
Advanced search Search tips

Issue 633337 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Sep 2016
Cc:
pauljensen@chromium.org
mef@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cronet: Findbugs build failure from @LASTCHANGE@ logic

Project Member Reported by siev...@chromium.org, Aug 1 2016 
I cannot build 'all' locally because of a findbugs failure in:

components/cronet/android/api/src/org/chromium/net/ApiVersion.template
and
components/cronet/android/java/src/org/chromium/net/impl/ImplVersion.template

It's because LAST_CHANGE.substring(0, 8) is out of range, so I assume @LASTCHANGE@ doesn't end up being set correctly.

If I change it to a string literal, it works. And this is the only build failure I get when compiling all targets.

Comment 1 by mef@chromium.org, Aug 1 2016 

What do you get in generated file [out/Debug]/gen/components/cronet/android/templates/cronet_api_version_java/org/chromium/net/ApiVersion.java ?

Comment 2 by mattm@chromium.org, Aug 2 2016

Components: -Internals>Network Internals>Network>Library

Comment 3 by pauljensen@chromium.org, Aug 12 2016

Labels: Needs-Feedback

Comment 4 by rdsmith@chromium.org, Aug 24 2016 

@sievers: Could you respond to the question in c#1?

Comment 5 by siev...@chromium.org, Aug 24 2016 

How do I build just that target?

Comment 6 by mef@chromium.org, Aug 25 2016 

"ninja -C <out> cronet_package" should do it. 

What is the host and target platform that you are building for? 
It should only build for Android.

Could you attach build log with errors?

Comment 7 by csharrison@chromium.org, Sep 9 2016 

ping sievers, is this still an issue?

Comment 8 by siev...@chromium.org, Sep 12 2016 

ninja: error: unknown target 'cronet_package'

> ping sievers, is this still an issue?

I don't know... why did anything change?

Comment 9 by mge...@chromium.org, Sep 13 2016

Status: WontFix (was: Untriaged)
I can't reproduce the issue. If you're still seeing it, please reopen and provide the information requested in comment 1 as well as what your gn args are.
►

Sign in to add a comment