New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633329 link

Starred by 3 users
Status: Assigned
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement a user-initiated abort metric

Project Member Reported by csharrison@chromium.org, Aug 1 2016 
We want ONE metric that adequately describes aborts. This will end up being a proxy metric as it is inevitable that we filter out real aborts in order to get actionable data.

This will require experimenting with page transitions, user_gesture bits, and UI events bubbled down into the page_load_metrics subsystem.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51

commit 8a0cfcc13e7be3684a6f6143160a3d655f2e1a51
Author: csharrison <csharrison@chromium.org>
Date: Thu Aug 04 18:03:31 2016

Add CLIENT_REDIRECT variants for page load metrics abort types

This patch adds support for client redirects aborting navigations. Right
now it only adds variants to the global abort metrics, because these
metrics are not user initiated and probably we should eventually end up
filtering them out.

Hopefully, this variant eats up a lot of the mass in non user-initiated
timescales in the current abort histograms.

BUG=557430,633329

Review-Url: https://codereview.chromium.org/2199953002
Cr-Commit-Position: refs/heads/master@{#409831}

[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51

commit 8a0cfcc13e7be3684a6f6143160a3d655f2e1a51
Author: csharrison <csharrison@chromium.org>
Date: Thu Aug 04 18:03:31 2016

Add CLIENT_REDIRECT variants for page load metrics abort types

This patch adds support for client redirects aborting navigations. Right
now it only adds variants to the global abort metrics, because these
metrics are not user initiated and probably we should eventually end up
filtering them out.

Hopefully, this variant eats up a lot of the mass in non user-initiated
timescales in the current abort histograms.

BUG=557430,633329

Review-Url: https://codereview.chromium.org/2199953002
Cr-Commit-Position: refs/heads/master@{#409831}

[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/8a0cfcc13e7be3684a6f6143160a3d655f2e1a51/tools/metrics/histograms/histograms.xml

Comment 4 by bmcquade@chromium.org, Dec 6 2016

Owner: bmcquade@chromium.org
I'll grab this bug since I'm now working in this area.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9

commit 20cc4e8c0e57f1e675a6354ce8916c02d68b88c9
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Dec 07 04:19:47 2016

Add UserInputTracker, which keeps track of recent user input events.

UserInputTracker keeps track of recent user input events, and allows
for consuming of those events. This class will be used in a subsequent
change https://codereview.chromium.org/2545593003 to heuristically
determine if an action such as a navigation was due to a user
interaction, by checking to see if a user input event was received
shortly before that action.

BUG=633329

Review-Url: https://codereview.chromium.org/2540183003
Cr-Commit-Position: refs/heads/master@{#436859}

[modify] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/BUILD.gn
[modify] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[add] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/page_load_metrics/user_input_tracker.cc
[add] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/page_load_metrics/user_input_tracker.h
[add] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/browser/page_load_metrics/user_input_tracker_unittest.cc
[modify] https://crrev.com/20cc4e8c0e57f1e675a6354ce8916c02d68b88c9/chrome/test/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae

commit 2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Dec 07 22:52:14 2016

Additional heuristic user interaction attribution for page load metrics

* Add UserInitiatedInfo struct, which keeps track of information related to
  whether an action was initiated by a user.

* Use UserInputTracker to heuristically determine if an action was
  triggered by a user interaction.

* Add additional histograms to better understand what the distributions
  look like for aborts with different user interaction attributes.

BUG=633329

Review-Url: https://codereview.chromium.org/2545593003
Cr-Commit-Position: refs/heads/master@{#437095}

[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/2adc9318634ff8c0fa0fc0a98b4be2c3aa9c49ae/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment