New issue
Advanced search Search tips

Issue 633326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Log how often home button is used

Project Member Reported by k...@chromium.org, Aug 1 2016

Issue description

We would like to understand the importance of the home button in the toolbar for future designs and therefore, would it be possible to log usage of the toolbar home button as a user action?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0f485c00e97fb265b84a93b462f5b4f21eaf0f6

commit c0f485c00e97fb265b84a93b462f5b4f21eaf0f6
Author: tedchoc <tedchoc@chromium.org>
Date: Mon Aug 01 21:20:54 2016

Add a user action for when the home button is clicked.

"Home" matches the existing desktop user action.

BUG= 633326 

Review-Url: https://codereview.chromium.org/2203553002
Cr-Commit-Position: refs/heads/master@{#409058}

[modify] https://crrev.com/c0f485c00e97fb265b84a93b462f5b4f21eaf0f6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Assigned)

Comment 3 by k...@chromium.org, Aug 1 2016

Great thanks - is it possible to merge this into m53?
Labels: Merge-Request-53

Comment 5 by dimu@chromium.org, Aug 1 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa8ecd518ce53218449d3620bc31e1875ddc6ff

commit aaa8ecd518ce53218449d3620bc31e1875ddc6ff
Author: Ted Choc <tedchoc@google.com>
Date: Mon Aug 01 22:39:15 2016

Add a user action for when the home button is clicked.

"Home" matches the existing desktop user action.

BUG= 633326 

Review URL: https://codereview.chromium.org/2199113002 .

Review-Url: https://codereview.chromium.org/2203553002
Cr-Original-Commit-Position: refs/heads/master@{#409058}
Cr-Commit-Position: refs/branch-heads/2785@{#453}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/aaa8ecd518ce53218449d3620bc31e1875ddc6ff/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Comment 7 by k...@chromium.org, Sep 14 2016

Issue 540831 has been merged into this issue.

Sign in to add a comment