New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633324 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Convert DragImageView to wm common types

Project Member Reported by jamescook@chromium.org, Aug 1 2016

Issue description

It's a dependency of ShelfView

 
Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035dc06b3166034bcf3a06a97304f8d80b04f06c

commit 035dc06b3166034bcf3a06a97304f8d80b04f06c
Author: jamescook <jamescook@chromium.org>
Date: Fri Aug 05 21:13:52 2016

mash: Migrate ash::DragImageView to wm common types

It is a dependency of ShelfView, which we're trying to convert.

* Change context parameter to be a WmWindow root_window.
* Initialize Widget using wm common utils.
* Use display::Display to get the device scale factor to size the image.
* Explicitly cancel a drag when a monitor is disconnected. This used to be
handled by marking the aura::Window as not owned by its parent. However,
drags are canceled anyway when monitor disconnects occur -- this just makes
it explicit.
* Added unit test for monitor disconnect during drag.

The DragDropController is not changed because it will likely need to be
refactored or replaced for mus. The new test is written with aura windows
for the same reason.

BUG= 633324 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2206033002
Cr-Commit-Position: refs/heads/master@{#410161}

[modify] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/ash.gyp
[add] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/common/drag_drop/OWNERS
[rename] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/common/drag_drop/drag_image_view.cc
[rename] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/common/drag_drop/drag_image_view.h
[modify] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/drag_drop/drag_drop_controller.cc
[modify] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/drag_drop/drag_drop_controller.h
[modify] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/drag_drop/drag_drop_controller_unittest.cc
[modify] https://crrev.com/035dc06b3166034bcf3a06a97304f8d80b04f06c/ash/shelf/shelf_view.cc

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment