New issue
Advanced search Search tips

Issue 633312 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

fix components/spellcheck/ renderer C4267 issue on windows x64

Project Member Reported by timvolod...@chromium.org, Aug 1 2016

Issue description

some examples of compile failures on win_chromium_x64_rel_ng trybot

-------------------------

:\b\c\b\win\src\components\spellcheck\renderer\spellcheck.cc(394): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck.cc(394): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck.cc(504): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck.cc(525): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
[15658/21546] CXX obj/components/translate/core/browser/unit_tests/translate_prefs_unittest.obj

------------------------

FAILED: obj/components/spellcheck/renderer/unit_tests/spellcheck_unittest.obj 
ninja -t msvc -e environment.x64 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/spellcheck/renderer/unit_tests/spellcheck_unittest.obj.rsp /c ../../components/spellcheck/renderer/spellcheck_unittest.cc /Foobj/components/spellcheck/renderer/unit_tests/spellcheck_unittest.obj /Fd"obj/components/spellcheck/renderer/unit_tests_cc.pdb"
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_unittest.cc(1441): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_unittest.cc(1441): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_unittest.cc(1530): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_unittest.cc(1554): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

-------------------


e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(135): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(135): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(138): warning C4267: 'argument': conversion from 'size_t' to 'base::HistogramBase::Sample', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(140): warning C4267: 'argument': conversion from 'size_t' to 'base::HistogramBase::Sample', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(161): warning C4267: 'argument': conversion from 'size_t' to 'base::HistogramBase::Sample', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(175): warning C4267: 'argument': conversion from 'size_t' to 'base::HistogramBase::Sample', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(235): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
e:\b\c\b\win\src\components\spellcheck\renderer\spellcheck_provider.cc(318): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
ninja: build stopped: subcommand failed.
 

Comment 1 Deleted

currently suppressed in the build file, see crrev.com/2198143002
Components: Infra>Platform>Buildbot
Cc: -petrcermak@chromium.org
Components: -Infra>Platform>Buildbot Build

Sign in to add a comment