New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633304 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 655388
issue 664002
issue 664667
issue 670402
issue 674176
issue 680509

Blocking:
issue 643240
issue 665225


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Power key on convertible ChromeOS devices should behave just like tablets

Project Member Reported by zelidrag@chromium.org, Aug 1 2016

Issue description

Pressing power key on convertible Chromebooks should not have UX that is any different then Android tablets. We currently just lock the device on power button press, I suggest that put it in suspend mode instead.

Not sure if this change should be handled on UI or power daemon's side.
 

Comment 1 by derat@chromium.org, Aug 1 2016

Cc: ejcaruso@chromium.org derat@chromium.org
Chrome already has the ability to ask powerd to suspend the system.

I don't think that this will work the way you'd like with Chrome OS's current notion of "suspending", though. I imagine we would need to do something much more lightweight, which would likely require some kernel work (which Sameer can probably comment on). I doubt that this could happen for M54.
We'll want to iterate on this to get it right. Ultimately, we'll want a "screen off" mode similar to what phones and tablets do, but I agree with derat@ that building that in time for 54 seems unrealistic.

tbuckley@ let's discuss offline.

Comment 3 by derat@chromium.org, Aug 1 2016

I'm happy to be involved in this discussion too if you want to set up a VC. :-)

For example: as a first pass, would it be desirable to just turn the screen off immediately when the button is tapped, while still keeping the existing inactivity delay for suspending the system? If so, I can start thinking about how to let Chrome request that from powerd.
The problem with just turning off the screen and not suspending is that might be surprising from a user-expectations POV.  The CPU would stay fully active and draining the battery. I could imagine that being really not what the user wants.  Especially since we lack a notification/alert system that would work in such an environment.

Let's tackle in 2 stages:
1: Change Chrome to have a tap on the power button while in touchview do a full suspend.
2: Start a separate longer term effort to figure out the CORRECT behavior here.

I'll file a tracking bug for the second. derat@ I'll make sure you're in on the conversation.
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by derat@chromium.org, Aug 1 2016

Sounds good. And just to make sure that it's clear: it's likely that with the initial full-suspend-on-tap change, a user might need to wait several seconds before they can wake up the device.

Comment 7 by warx@chromium.org, Oct 7 2016

Labels: -M-54 M-56
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d044601c1b04c886e80ddf746fc93840c68b25e

commit 8d044601c1b04c886e80ddf746fc93840c68b25e
Author: warx <warx@chromium.org>
Date: Wed Oct 12 17:06:18 2016

Roll cros_system_api to for power_manager:[S,G]etBacklightsForcedOff constants

Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/d726d6e8e26c53689f9d4d732d6650ec296722e3

BUG= 633304 
TEST=none

Review-Url: https://codereview.chromium.org/2407123003
Cr-Commit-Position: refs/heads/master@{#424768}

[modify] https://crrev.com/8d044601c1b04c886e80ddf746fc93840c68b25e/DEPS

Comment 9 by warx@chromium.org, Oct 12 2016

Blockedon: 655388
Blocking: 643240

Comment 12 by warx@chromium.org, Nov 10 2016

Blockedon: 664002

Comment 13 by warx@chromium.org, Nov 10 2016

Labels: -M-56 M-57

Comment 14 by warx@chromium.org, Nov 11 2016

Blockedon: 664667
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72135ade1aacb9f9fcfe61f8a704567a98cc3178

commit 72135ade1aacb9f9fcfe61f8a704567a98cc3178
Author: warx <warx@chromium.org>
Date: Mon Nov 14 22:47:38 2016

Tablet-like power button behavior on Convertible/Tablet ChromeOS devices

Changes:
device consistency: convertible/tablet chromeos devices follow the behavior described in go/touchview-power convertible behavior; other devices follow clamshell behavior.

BUG= 633304 
TEST=manually test; add unitttest

Review-Url: https://codereview.chromium.org/2474913004
Cr-Commit-Position: refs/heads/master@{#431931}

[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/BUILD.gn
[add] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/system/chromeos/power/tablet_power_button_controller.cc
[add] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/system/chromeos/power/tablet_power_button_controller.h
[add] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/wm/lock_state_controller.h
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/wm/power_button_controller.cc
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/ash/wm/power_button_controller.h
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178/chromeos/dbus/fake_power_manager_client.h

Comment 16 by warx@chromium.org, Nov 15 2016

Blocking: 665225
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b31faaf2a38e64e3950e40f9558ece3fdef4307

commit 2b31faaf2a38e64e3950e40f9558ece3fdef4307
Author: horo <horo@chromium.org>
Date: Tue Nov 15 03:57:54 2016

Revert of Tablet-like power button behavior on Convertible/Tablet ChromeOS devices (patchset #12 id:300001 of https://codereview.chromium.org/2474913004/ )

Reason for revert:
Caused failures of AshTestHelperTest.AshTestHelper in ash_unittests.
See  http://crbug.com/665278 

BUG= 665278 

Original issue's description:
> Tablet-like power button behavior on Convertible/Tablet ChromeOS devices
>
> Changes:
> device consistency: convertible/tablet chromeos devices follow the behavior described in go/touchview-power convertible behavior; other devices follow clamshell behavior.
>
> BUG= 633304 
> TEST=manually test; add unitttest
>
> Committed: https://crrev.com/72135ade1aacb9f9fcfe61f8a704567a98cc3178
> Cr-Commit-Position: refs/heads/master@{#431931}

TBR=derat@chromium.org,warx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 633304 

Review-Url: https://codereview.chromium.org/2496043004
Cr-Commit-Position: refs/heads/master@{#432089}

[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/ash/BUILD.gn
[delete] https://crrev.com/8c16443d571c056044eece9afb1066308fb0c593/ash/system/chromeos/power/tablet_power_button_controller.cc
[delete] https://crrev.com/8c16443d571c056044eece9afb1066308fb0c593/ash/system/chromeos/power/tablet_power_button_controller.h
[delete] https://crrev.com/8c16443d571c056044eece9afb1066308fb0c593/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/ash/wm/lock_state_controller.h
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/ash/wm/power_button_controller.cc
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/ash/wm/power_button_controller.h
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/2b31faaf2a38e64e3950e40f9558ece3fdef4307/chromeos/dbus/fake_power_manager_client.h

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73

commit 168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73
Author: warx <warx@chromium.org>
Date: Tue Nov 15 16:45:30 2016

[Reland-fixing asan failure] Tablet-like power button behavior on Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior described in go/touchview-power convertible behavior; other devices follow clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two threads, UI thread and DBusThread. Thus raw pointer may cause "use after free address error".

BUG= 633304 
TEST=manually test; add unitttest; manually asan test.

Review-Url: https://codereview.chromium.org/2504523002
Cr-Commit-Position: refs/heads/master@{#432196}

[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/BUILD.gn
[add] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/system/chromeos/power/tablet_power_button_controller.cc
[add] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/system/chromeos/power/tablet_power_button_controller.h
[add] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/wm/lock_state_controller.h
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/wm/power_button_controller.cc
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/ash/wm/power_button_controller.h
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73/chromeos/dbus/fake_power_manager_client.h

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6518074e118be1d1128595f6206d3c1a5db670e6

commit 6518074e118be1d1128595f6206d3c1a5db670e6
Author: warx <warx@chromium.org>
Date: Thu Nov 17 22:53:27 2016

SetBacklightsForcedOff induced BrightnessChanged signal is not user_initiated

SetBacklightsForcedOff is designed to be not user_initiated, thus any call for SetBacklightsForcedOff will not trigger UI bubble. This CL is fixing the wrong usage in TabletPowerButtonControllerTest.

BUG= 633304 
TEST=this cl should not break anything

Review-Url: https://codereview.chromium.org/2511203002
Cr-Commit-Position: refs/heads/master@{#432999}

[modify] https://crrev.com/6518074e118be1d1128595f6206d3c1a5db670e6/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93aefeb6fd6780215aa647dfb16e840d22ef0388

commit 93aefeb6fd6780215aa647dfb16e840d22ef0388
Author: warx <warx@chromium.org>
Date: Tue Nov 22 20:08:33 2016

Ignore OnKeyEvent for VKEY_POWER because it is handled by PowerButtonEvent

Before this change, today I meet the issue (it doesn't happen frequently) that pressing-and-releasing power button should SetBacklightsForcedOff(true). However, screen is turned off and then turned on. Checking powerd log that, there is Stop SetBacklightsForcedOff request. It is coming from VKEY_POWER keyevent timing issue. The right design should also avoid this key event.

BUG= 633304 
TEST=cannot see the bug for many taps; add unittest.

Review-Url: https://codereview.chromium.org/2521103002
Cr-Commit-Position: refs/heads/master@{#433954}

[modify] https://crrev.com/93aefeb6fd6780215aa647dfb16e840d22ef0388/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/93aefeb6fd6780215aa647dfb16e840d22ef0388/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/93aefeb6fd6780215aa647dfb16e840d22ef0388/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/93aefeb6fd6780215aa647dfb16e840d22ef0388/chromeos/dbus/fake_power_manager_client.h

Comment 21 by warx@chromium.org, Dec 1 2016

Blockedon: 670402
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7

commit 4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7
Author: warx <warx@chromium.org>
Date: Sat Dec 03 22:38:50 2016

Enabled/disable touch screen in TabletPowerButtonController

By exposing several apis in input_device_settings.h and add new local pref for TouchScreenEnabled, we can disable touch screen events when backlights are forced off so that no screen UI events can be triggered and enable touch screen when stopping backlights forced off is called properly.

BUG=655388
BUG= 633304 
TEST=manual test on device, and add test coverage.
also test that this added behavior is compatible with toggle touchscreen shortcut
The shortcut induced in https://codereview.chromium.org/2467023004 is per user pref, backlights-forced-off related touch screen status is per device pref. The final hardware touchscreen status is determined by the rule: enabled_in_local_state && enabled_in_user_pref

Review-Url: https://codereview.chromium.org/2533373002
Cr-Commit-Position: refs/heads/master@{#436177}

[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/common/accelerators/debug_commands.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/common/shell_delegate.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/ash/test/test_shell_delegate.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/chromeos/system/input_device_settings.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/chromeos/system/input_device_settings.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/common/pref_names.cc
[modify] https://crrev.com/4c8baedbf7a0b83ec7b5fd77dc1f5d5627fe6dd7/chrome/common/pref_names.h

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3dd2cafa37a9985dc4907ee364d9229b6c0006a

commit d3dd2cafa37a9985dc4907ee364d9229b6c0006a
Author: warx <warx@chromium.org>
Date: Mon Dec 05 23:27:07 2016

ash: Start shutdown timer on post-resume power button press

Changes:
Start shutdown timer on convertible Chromebooks when the power button is pressed just after resume. Continue avoiding forcing the display off in response to the button being released in this case, though.

BUG= 633304 
TEST=device test, and test coverage

Review-Url: https://codereview.chromium.org/2546303002
Cr-Commit-Position: refs/heads/master@{#436447}

[modify] https://crrev.com/d3dd2cafa37a9985dc4907ee364d9229b6c0006a/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/d3dd2cafa37a9985dc4907ee364d9229b6c0006a/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/d3dd2cafa37a9985dc4907ee364d9229b6c0006a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Comment 24 by derat@chromium.org, Dec 14 2016

Blockedon: 674176

Comment 25 by derat@chromium.org, Dec 14 2016

Status: Started (was: Assigned)
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edd30010faf05e3c2b990025e55525e7769b1d4

commit 2edd30010faf05e3c2b990025e55525e7769b1d4
Author: derat <derat@chromium.org>
Date: Wed Dec 14 23:08:48 2016

chromeos: Tie tablet power button to --enable-touchview.

Remove the --ash-enable-tablet-power-button switch and
instead enable tablet-style power button behavior whenever
the --enable-touchview switch is set. This matches the logic
for enabling the old "quick lock" power button behavior that
was replaced by tablet-style behavior.

BUG= 674176 , 633304 

Review-Url: https://codereview.chromium.org/2575183002
Cr-Commit-Position: refs/heads/master@{#438663}

[modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/common/ash_switches.cc
[modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/common/ash_switches.h
[modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/wm/power_button_controller.cc
[modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/chrome/browser/chromeos/login/chrome_restart_request.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0923a66bb239acfec65cdff715f66c4171bb02

commit 4d0923a66bb239acfec65cdff715f66c4171bb02
Author: warx <warx@chromium.org>
Date: Fri Dec 16 23:12:49 2016

Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG= 633304 
TEST=automated tests

Review-Url: https://codereview.chromium.org/2579703003
Cr-Commit-Position: refs/heads/master@{#439226}

[modify] https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02/ash/common/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02/ash/common/wm/maximize_mode/maximize_mode_controller.h
[modify] https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5567e091c5aafff29f019055685e962979301a

commit 1b5567e091c5aafff29f019055685e962979301a
Author: warx <warx@chromium.org>
Date: Wed Jan 11 22:19:42 2017

ash: Tune shutdown timer in TabletPowerButtonController and shutdown
white animation speed

Changes:
(1) shutdown_timer_ in TabletPowerButtonController changes from 1000ms to 500ms.
(2) animation_speed_shutdown is set to 2500ms for touch view enabled device case.

This change follows the new timing guideline in go/touchview-power.

BUG= 633304 
TEST=tested on device

Review-Url: https://codereview.chromium.org/2622103003
Cr-Commit-Position: refs/heads/master@{#443012}

[modify] https://crrev.com/1b5567e091c5aafff29f019055685e962979301a/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/1b5567e091c5aafff29f019055685e962979301a/ash/wm/session_state_animator.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80fccc61857e261e52bed6c44a6d4f0ec97aff72

commit 80fccc61857e261e52bed6c44a6d4f0ec97aff72
Author: warx <warx@chromium.org>
Date: Thu Jan 12 04:48:34 2017

cleanup: Remove stylus check within OnMouseEvent for TabletPowerButtonController

Changes:
stylus 'touch' event is no longer mouse event based on the cl: https://codereview.chromium.org/2507503002/, which leads to this cleanup change.

BUG= 633304 
TEST=tested that stylus touch event will not wake the device (both in
laptop mode and tablet mode) on kevin.

Review-Url: https://codereview.chromium.org/2621373003
Cr-Commit-Position: refs/heads/master@{#443154}

[modify] https://crrev.com/80fccc61857e261e52bed6c44a6d4f0ec97aff72/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/80fccc61857e261e52bed6c44a6d4f0ec97aff72/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Comment 30 by warx@chromium.org, Jan 12 2017

Blockedon: 680509
Project Member

Comment 31 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b1b7e758f10253dc293c05006c8695fe58079e

commit 88b1b7e758f10253dc293c05006c8695fe58079e
Author: warx <warx@chromium.org>
Date: Thu Jan 12 16:18:43 2017

ash: Add one second grace period For LockScreenIfRequired

Changes:
Add one second grace period For LockScreenIfRequired. Basically, an one second OneShotTimer is used to set/reset the behavior.

BUG= 633304 
BUG= 680509 
TEST=device test, and modify test coverage

Review-Url: https://codereview.chromium.org/2620383003
Cr-Commit-Position: refs/heads/master@{#443254}

[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96

commit bb674e1d750b23fe732ce6f37484e1ca3a4e9d96
Author: warx <warx@chromium.org>
Date: Thu Jan 19 18:10:18 2017

Revert "ash: Add one second grace period For LockScreenIfRequired"

This reverts commit 88b1b7e758f10253dc293c05006c8695fe58079e.

changes:
Revert the one second grace period for LockScreenIfRequired for m57 and tot, and explore it later.

BUG= 633304 
BUG= 680509 

Review-Url: https://codereview.chromium.org/2640333002
Cr-Commit-Position: refs/heads/master@{#444787}

[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Comment 33 by warx@chromium.org, Feb 9 2017

Status: Fixed (was: Started)
Stage one is landed in M57. Mark this as fixed as it is better to open another tracking bug for Doze/Lucid-sleep/power-management.
Status: Verified (was: Fixed)
verified on Cyan with version 57.0.2987.75/9202.37.0(Official Build)beta-channel Cyan
 Issue 693115  has been merged into this issue.
Components: UI>Shell>TouchView
Components: -UI>TouchView

Sign in to add a comment