New issue
Advanced search Search tips

Issue 633280 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 613765



Sign in to add a comment

Raise timeout exception in stateful_update

Project Member Reported by xixuan@chromium.org, Aug 1 2016

Issue description

The stateful update process is designed not to raise errors due to that rootfs update can be adopted in the following to continue auto-update. 

However, a timer is set for the whole auto-update process in case that this process is hung. This timeout exception may be caught by stateful update and won't be raised.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/2aca0ac5103f3216e307d07bd3e75d890b9746c5

commit 2aca0ac5103f3216e307d07bd3e75d890b9746c5
Author: xixuan <xixuan@google.com>
Date: Fri Jul 29 19:02:06 2016

dev: let 'timeout' exception raised.

The stateful update process won't raise errors since rootfs update can be
adopted to continue auto-update. However, a timer is set for the whole
auto-update process in case that this process is hung. This timeout exception
may be caught by stateful update and won't be raised.

This CL is used to raise 'timeout' exception in auto-update, to make sure that
the auto-update process terminates itself when it meets the deadline.

BUG= chromium:633280 
TEST=Locally ran 'ds.auto_update([dut], [image_path])';
Ran 'repair' for dut from local autotest instance;
Ran unittest, devserver_integration_test.

Changes to be committed:
       modified:   cros_update.py

Change-Id: Ib52cd9204b8152a83011a6b2f13fc16656fdb60c
Reviewed-on: https://chromium-review.googlesource.com/364622
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/2aca0ac5103f3216e307d07bd3e75d890b9746c5/cros_update.py

Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment