New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633274 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 518942



Sign in to add a comment

bluetooth: Mac returns adapter not available when adapter is off.

Project Member Reported by ortuno@chromium.org, Aug 1 2016

Issue description

Mac should return adapter is off rather than unavailable.
 

Comment 1 by ortuno@chromium.org, Aug 17 2016

Owner: ortuno@chromium.org
Status: Started (was: Available)
wip at: http://crrev.com/2248033006
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/784971913adcc32bdb22a92da6ac237a7de88a2b

commit 784971913adcc32bdb22a92da6ac237a7de88a2b
Author: ortuno <ortuno@chromium.org>
Date: Fri Aug 19 18:28:11 2016

bluetooth: Return false for IsPresent only when bluetooth is not supported

BUG= 633274 

Review-Url: https://codereview.chromium.org/2248033006
Cr-Commit-Position: refs/heads/master@{#413192}

[modify] https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b/device/bluetooth/bluetooth_adapter_mac.mm

Comment 3 by ortuno@chromium.org, Aug 19 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f007849dc7d77512307a59341fb2d35a1a0ee51

commit 7f007849dc7d77512307a59341fb2d35a1a0ee51
Author: tasak <tasak@google.com>
Date: Mon Aug 22 04:05:37 2016

Revert of bluetooth: Return false for IsPresent only when bluetooth is not supported (patchset #1 id:1 of https://codereview.chromium.org/2248033006/ )

Reason for revert:
device_unittests: BluetoothTest.ConstructDefaultAdapter is failing.

Original issue's description:
> bluetooth: Return false for IsPresent only when bluetooth is not supported
>
> BUG= 633274 
>
> Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
> Cr-Commit-Position: refs/heads/master@{#413192}

TBR=jyasskin@chromium.org,ortuno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 633274 

Review-Url: https://codereview.chromium.org/2262033002
Cr-Commit-Position: refs/heads/master@{#413402}

[modify] https://crrev.com/7f007849dc7d77512307a59341fb2d35a1a0ee51/device/bluetooth/bluetooth_adapter_mac.mm

Comment 5 by treib@chromium.org, Aug 22 2016

Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80936aa92bb2c378fb3729f67b1e35712920282a

commit 80936aa92bb2c378fb3729f67b1e35712920282a
Author: ortuno <ortuno@chromium.org>
Date: Tue Aug 23 00:04:56 2016

bluetooth: Return false for IsPresent only when bluetooth is not supported

BUG= 633274 

Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
Review-Url: https://codereview.chromium.org/2248033006
Cr-Original-Commit-Position: refs/heads/master@{#413192}
Cr-Commit-Position: refs/heads/master@{#413589}

[modify] https://crrev.com/80936aa92bb2c378fb3729f67b1e35712920282a/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/80936aa92bb2c378fb3729f67b1e35712920282a/device/bluetooth/bluetooth_adapter_unittest.cc

Comment 7 by ortuno@chromium.org, Aug 23 2016

Status: Fixed (was: Started)

Sign in to add a comment