Remove Finch experiment configs and set Media Router to be enabled by default |
|||||||
Issue descriptionNow that we've launched to 100% of users, we should remove the Finch experiment config and ensure that Media Router is enabled by default for all users, across all channels. We can probably make MR default "on" for M53 and then remove the Finch experiment once M53 goes to stable.
,
Sep 1 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72217db0c2b09929ba393414493e0d0dd0d6e823 commit 72217db0c2b09929ba393414493e0d0dd0d6e823 Author: imcheng <imcheng@chromium.org> Date: Fri Sep 09 17:52:50 2016 [Media Router] Enable MR by default now that it is at 100% in stable. BUG= 633269 Review-Url: https://codereview.chromium.org/2307803002 Cr-Commit-Position: refs/heads/master@{#417626} [modify] https://crrev.com/72217db0c2b09929ba393414493e0d0dd0d6e823/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/72217db0c2b09929ba393414493e0d0dd0d6e823/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc [modify] https://crrev.com/72217db0c2b09929ba393414493e0d0dd0d6e823/extensions/common/feature_switch.cc
,
Sep 12 2016
Requesting merge for https://codereview.chromium.org/2307803002 and https://codereview.chromium.org/2311533002/
,
Sep 12 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6 commit af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6 Author: Derek Cheng <imcheng@chromium.org> Date: Mon Sep 12 16:32:41 2016 [Media Router] Enable MR by default now that it is at 100% in stable. BUG= 633269 Review-Url: https://codereview.chromium.org/2307803002 Cr-Commit-Position: refs/heads/master@{#417626} (cherry picked from commit 72217db0c2b09929ba393414493e0d0dd0d6e823) Review URL: https://codereview.chromium.org/2332853002 . Cr-Commit-Position: refs/branch-heads/2840@{#301} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/extensions/common/feature_switch.cc
,
Sep 12 2016
,
Sep 14 2016
Tested the same on win10 and mac 10.11.6 chrome version 54.0.2840.27 - Observed that the flag Media Router displays "Default" in chrome://flags Please find the screenshot Could you please let us know if this is the expected behavior else provide us with TEST steps to verify the fix manually.
,
Sep 14 2016
Verified as per #8
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6 commit af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6 Author: Derek Cheng <imcheng@chromium.org> Date: Mon Sep 12 16:32:41 2016 [Media Router] Enable MR by default now that it is at 100% in stable. BUG= 633269 Review-Url: https://codereview.chromium.org/2307803002 Cr-Commit-Position: refs/heads/master@{#417626} (cherry picked from commit 72217db0c2b09929ba393414493e0d0dd0d6e823) Review URL: https://codereview.chromium.org/2332853002 . Cr-Commit-Position: refs/branch-heads/2840@{#301} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc [modify] https://crrev.com/af9abbbfcad2cdbe6a340a2fb64cdd64189e9fd6/extensions/common/feature_switch.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Aug 5 2016