cleanup content/browser/{media/}webrtc files/test class names |
||||
Issue description
- All these files have classes that do not correspond to the file
names or viceversa:
content/browser/webrtc/webrtc_content_browsertest_base.h:17:class WebRtcContentBrowserTest: public ContentBrowserTest {
content/browser/webrtc/webrtc_browsertest_audio.cc:31:class MAYBE_WebRtcBrowserAudioTest : public WebRtcContentBrowserTest {
content/browser/webrtc/webrtc_browsertest_data.cc:31:class MAYBE_WebRtcBrowserDataTest : public WebRtcContentBrowserTest {
they should be WebRtc...BrowserTest or WebRtc..Test
- This file has a bunch of test, none of them complying to the file's name
--> remove "Browser" from the class names
content/browser/webrtc/webrtc_ip_permissions_browsertest.cc:54:class MAYBE_WebRtcBrowserIPPermissionGrantedTest
content/browser/webrtc/webrtc_ip_permissions_browsertest.cc:77:class MAYBE_WebRtcBrowserIPPermissionDeniedTest
content/browser/webrtc/webrtc_ip_permissions_browsertest.cc:99:class MAYBE_WebRtcBrowserIPPolicyPublicAndPrivateInterfacesTest
content/browser/webrtc/webrtc_ip_permissions_browsertest.cc:123:class MAYBE_WebRtcBrowserIPPolicyPublicInterfaceOnlyTest
content/browser/webrtc/webrtc_ip_permissions_browsertest.cc:146:class MAYBE_WebRtcBrowserIPPolicyDisableUdpTest
This test should go to a file of its own:
content/browser/webrtc/webrtc_getusermedia_browsertest.cc:734:class WebRtcConstraintsBrowserTest
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e18dfb3f7114bc96d2251c1b151944fbbdf7074 commit 0e18dfb3f7114bc96d2251c1b151944fbbdf7074 Author: ehmaldonado <ehmaldonado@chromium.org> Date: Wed Aug 03 11:09:44 2016 Rename webrtc_browsertest_{audio, data} to agree with the class name. BUG= 633257 Review-Url: https://codereview.chromium.org/2204773004 Cr-Commit-Position: refs/heads/master@{#409486} [rename] https://crrev.com/0e18dfb3f7114bc96d2251c1b151944fbbdf7074/content/browser/webrtc/webrtc_audio_browsertest.cc [rename] https://crrev.com/0e18dfb3f7114bc96d2251c1b151944fbbdf7074/content/browser/webrtc/webrtc_data_browsertest.cc [modify] https://crrev.com/0e18dfb3f7114bc96d2251c1b151944fbbdf7074/content/content_tests.gypi
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41f5b700af96121fa474916afcf522c51d029894 commit 41f5b700af96121fa474916afcf522c51d029894 Author: mcasas <mcasas@chromium.org> Date: Wed Aug 03 20:19:41 2016 webrtc content_browsetests file/class naming cleanup *No new code * This CL cleans up a bit of class/file naming inconsistencies in webrtc content_browsertests: - content/browser/webrtc/webrtc_ip_permissions_browsertest.cc: renamed classes WebRtcBrowserIP* --> WebRtcIP*, to comply with file and test naming conventions - s/WebRtcContentBrowserTest/WebRtcContentBrowserTestBase/ everywhere - git cl format of the remaining. BUG= 633257 Review-Url: https://codereview.chromium.org/2205423002 Cr-Commit-Position: refs/heads/master@{#409609} [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_audio_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_content_browsertest_base.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_content_browsertest_base.h [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_data_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_datachannel_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_getusermedia_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_ip_permissions_browsertest.cc [modify] https://crrev.com/41f5b700af96121fa474916afcf522c51d029894/content/browser/webrtc/webrtc_media_recorder_browsertest.cc
,
Aug 4 2016
I assume this is fixed now.
,
Aug 4 2016
still missing extracting WebRtcConstraintsBrowserTest
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a976e3faaa9d37acd126b901809d5cc4fc78f98 commit 0a976e3faaa9d37acd126b901809d5cc4fc78f98 Author: mcasas <mcasas@chromium.org> Date: Thu Aug 11 13:57:40 2016 Extract content_browsertest WebRtcConstraintsBrowserTest into its own file The original file is too large, and files are cheap. Also, said WebRtcConstraintsBrowserTest will need beefing up soon as the new constraint grammar(s) are being introduced. No new coded added, just shoveling code around. BUG= 633257 Review-Url: https://codereview.chromium.org/2233683003 Cr-Commit-Position: refs/heads/master@{#411317} [add] https://crrev.com/0a976e3faaa9d37acd126b901809d5cc4fc78f98/content/browser/webrtc/webrtc_constraints_browsertest.cc [modify] https://crrev.com/0a976e3faaa9d37acd126b901809d5cc4fc78f98/content/browser/webrtc/webrtc_getusermedia_browsertest.cc [modify] https://crrev.com/0a976e3faaa9d37acd126b901809d5cc4fc78f98/content/content_tests.gypi
,
Aug 11 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, Aug 1 2016Owner: ehmaldonado@chromium.org
Status: Assigned (was: Available)