New issue
Advanced search Search tips

Issue 633250 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

samus: increase low_battery_shutdown_percent

Project Member Reported by tbroch@chromium.org, Aug 1 2016

Issue description

The EC low battery shutdown,

https://chromium.googlesource.com/chromiumos/platform/ec/+/firmware-samus-6300.B/include/battery.h

/*
 * Shut down main processor and/or hibernate EC when discharging and battery
 * level < this level.
 */
#define BATTERY_LEVEL_SHUTDOWN		  3

and the AP low battery shutdown,

https://chromium.googlesource.com/chromiumos/overlays/board-overlays.git/+/master/overlay-samus/chromeos-base/chromeos-bsp-samus/files/powerd_prefs/low_battery_shutdown_percent

3.0

are the same.  This can lead to a race in which the EC shuts down the AP uncleanly.  

Lets increase the AP side to provide a 1% buffer
 
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/#/c/364835/
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/010dcaf1b9f73f6301d0df604069cf873eded7df

commit 010dcaf1b9f73f6301d0df604069cf873eded7df
Author: Todd Broch <tbroch@chromium.org>
Date: Mon Aug 01 17:08:56 2016

samus: Increase low_battery_shutdown_percent to 4.

BUG= chromium:633250 
TEST=manual,
 emerge-samus chromeos-bsp-samus
 cat /build/samus/usr/share/power_manager/board_specific
 4.0

Change-Id: I9972d574cc0159b9e182ddcb40456db1f7346ff4
Reviewed-on: https://chromium-review.googlesource.com/364835
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[rename] https://crrev.com/010dcaf1b9f73f6301d0df604069cf873eded7df/overlay-samus/chromeos-base/chromeos-bsp-samus/chromeos-bsp-samus-0.0.2-r11.ebuild
[modify] https://crrev.com/010dcaf1b9f73f6301d0df604069cf873eded7df/overlay-samus/chromeos-base/chromeos-bsp-samus/files/powerd_prefs/low_battery_shutdown_percent

Comment 3 by tbroch@chromium.org, Aug 15 2016

Status: Fixed (was: Started)

Sign in to add a comment