OobeLocalizationTest.LocalizationTest is flakey |
||||||||||
Issue descriptionThere have been several recent failures of OobeLocalizationTest.LocalizationTest:
,
Aug 1 2016
There have been several recent failures of OobeLocalizationTest.LocalizationTest: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23857 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23846 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23839
,
Aug 2 2016
This just failed again: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23928 Oddly, there is no clear indication of why the test failed, the output all looks like this: [ RUN ] StructSequence/OobeLocalizationTest.LocalizationTest/7 HTTPS server started on 127.0.0.1:37918... sending server_data: {"host": "127.0.0.1", "port": 37918} (36 bytes) [17517:17517:0802/095215:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [17517:17517:0802/095215:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":9". [17517:17517:0802/095215:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [17517:17539:0802/095215:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [1266/1266] StructSequence/OobeLocalizationTest.LocalizationTest/7 (454 ms) There is a top level message: "shard #0 isolated out", suggesting that maybe some side effect of the test is preventing the builder from receiving the result from the shard?
,
Aug 2 2016
Looking at oobe_localization_browsertest.cc: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/oobe_localization_browsertest.cc?q=oobe_localization_browsertest.cc&sq=package:chromium&dr I see several uses of base::RunLoop with no timeouts, making this test very difficult to debug when this fails. We need to add timeouts so that we know where the code is failing and add error messages for unexpected conditions.
,
Aug 4 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50 commit 7d82f6f3361bd36fbd4e36ac0140506d4be2bf50 Author: alemate <alemate@chromium.org> Date: Fri Aug 05 22:02:50 2016 OobeLocalizationTest.LocalizationTest : implement test timeouts. This CL removes race in LocalizationTest and also adds timeouts to debug test flakiness. BUG= 633246 Review-Url: https://codereview.chromium.org/2216433002 Cr-Commit-Position: refs/heads/master@{#410179} [modify] https://crrev.com/7d82f6f3361bd36fbd4e36ac0140506d4be2bf50/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
,
Aug 6 2016
,
Aug 12 2016
This is still flaky. Sample build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/24477 Error from log file: [ RUN ] StructSequence/OobeLocalizationTest.LocalizationTest/2 HTTPS server started on 127.0.0.1:48173... sending server_data: {"host": "127.0.0.1", "port": 48173} (36 bytes) [11752:11752:0811/145632:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [11752:11752:0811/145632:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":9". [11752:11770:0811/145632:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [1280/1280] StructSequence/OobeLocalizationTest.LocalizationTest/2 (388 ms)
,
Aug 12 2016
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76962882c2d5eb041fd83735db45de1483626b23 commit 76962882c2d5eb041fd83735db45de1483626b23 Author: samli <samli@chromium.org> Date: Fri Aug 12 01:57:53 2016 Disabling OobeLocalizationTest.LocalizationTest NOTRY=true TBR=kolos@chromium.org BUG= 633246 Review-Url: https://codereview.chromium.org/2243733002 Cr-Commit-Position: refs/heads/master@{#411513} [modify] https://crrev.com/76962882c2d5eb041fd83735db45de1483626b23/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c566b2a473f50c50440f32ffaa5d80da6fb9e456 commit c566b2a473f50c50440f32ffaa5d80da6fb9e456 Author: kolos <kolos@chromium.org> Date: Fri Aug 12 08:32:45 2016 Disabling OobeLocalizationTest.LocalizationTest (fixed typo) Fix a typo in the previous CL (https://codereview.chromium.org/2243733002) that should have disabled OobeLocalizationTest.LocalizationTest NOTRY=true BUG= 633246 TBR=samli@chromium.org,alemate@chromium.org Review-Url: https://codereview.chromium.org/2243493007 Cr-Commit-Position: refs/heads/master@{#411583} [modify] https://crrev.com/c566b2a473f50c50440f32ffaa5d80da6fb9e456/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
,
Nov 9
Looks like this test was disabled - please reopen if bug is still relevant.
,
Nov 9
We need to re-enable it.
,
Nov 13
,
Nov 14
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce17133d6d960ab6acf8fce18bd81ead2636c7f commit 6ce17133d6d960ab6acf8fce18bd81ead2636c7f Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Dec 01 00:15:37 2018 Chrome OS: Fix and re-enable OobeLocalizationTest Bug: 633246 Change-Id: Id6c302696c955401a991c0235d86f05d03019036 Reviewed-on: https://chromium-review.googlesource.com/c/1355045 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#612867} [modify] https://crrev.com/6ce17133d6d960ab6acf8fce18bd81ead2636c7f/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
,
Dec 1
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ab0a8cc946d5a79d3aae2152907ec9a9026daf commit f7ab0a8cc946d5a79d3aae2152907ec9a9026daf Author: calamity <calamity@chromium.org> Date: Mon Dec 03 04:36:39 2018 Revert "Chrome OS: Fix and re-enable OobeLocalizationTest" This reverts commit 6ce17133d6d960ab6acf8fce18bd81ead2636c7f. Reason for revert: Failing on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16712 Original change's description: > Chrome OS: Fix and re-enable OobeLocalizationTest > > Bug: 633246 > Change-Id: Id6c302696c955401a991c0235d86f05d03019036 > Reviewed-on: https://chromium-review.googlesource.com/c/1355045 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612867} TBR=alemate@chromium.org,jdufault@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 633246 Change-Id: I8d8994bc4d89fd87427d055a2946e6168a4d2f89 Reviewed-on: https://chromium-review.googlesource.com/c/1358106 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#613001} [modify] https://crrev.com/f7ab0a8cc946d5a79d3aae2152907ec9a9026daf/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36736b2da7bc3d11dd67fc1100c930a278a86d79 commit 36736b2da7bc3d11dd67fc1100c930a278a86d79 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Dec 05 21:42:49 2018 Chrome OS: Fix and re-enable OobeLocalizationTest This is re-land of the https://chromium-review.googlesource.com/c/1355045 with more tests fixed. Bug: 633246 Change-Id: I6c889b863858a0a364a05ffcfc4d2a2dda00194d Reviewed-on: https://chromium-review.googlesource.com/c/1362476 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#614112} [modify] https://crrev.com/36736b2da7bc3d11dd67fc1100c930a278a86d79/chrome/browser/chromeos/login/oobe_localization_browsertest.cc [modify] https://crrev.com/36736b2da7bc3d11dd67fc1100c930a278a86d79/chrome/browser/chromeos/login/ui/input_events_blocker.cc [modify] https://crrev.com/36736b2da7bc3d11dd67fc1100c930a278a86d79/chrome/browser/chromeos/login/ui/login_display_host_webui.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by steve...@chromium.org
, Aug 1 2016Labels: -Pri-3 OS-Chrome Pri-1