Issue metadata
Sign in to add a comment
|
WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d failing on Android devices |
||||||||||||||||||||||
Issue descriptionThe following failures appeared on the Nexus 5, Nexus 9 and Pixel C GPU FYI bots: WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d_rgb_rgb_unsigned_byte WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d_rgb_rgb_unsigned_short_5_6_5 WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d_rgba_rgba_unsigned_byte WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance_conformance_textures_image_bitmap_from_image_data_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 This is the first failing build for the Nexus 5 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205%29/builds/909 https://codereview.chromium.org/2183323003 seems likely to cause this failure as these tests stress ImageBitmap and the premultiplied alpha setting. xidachen@, can you take a look? I didn't simply revert your CL because it seems there already are commits building on top of it. Also CCing junov@ as he work on canvas and is on the desk next to mine (beware the "friendly pings").
,
Aug 1 2016
Upgrading to P1 and marking regression. It looks like this is related to Issue 627855, so blocking that on this bug.
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909e62f21bef265278f12a398af788e2c02060f8 commit 909e62f21bef265278f12a398af788e2c02060f8 Author: xidachen <xidachen@chromium.org> Date: Tue Aug 02 17:40:54 2016 Fix tests: conformance_textures_image_bitmap_from_image_data on Android Right now these tests are failing, and the reason is that in our previous CL here: https://codereview.chromium.org/2183323003, we made a change such that the function swizzleImageData() is called only when kN32_SkColorType == kBGRA_8888_SkColorType. That means on the Android platform this function will not be called. What I didn't realize is that this function itself also contains flip the input data vertically which is required when flipY is true. Right now on the Android bots, whenever the flipY is true, these tests will fail. This CL changes the function swizzleImageData() so that this function determines whether swizle is needed or not based on this: kN32_SkColorType == kBGRA_8888_SkColorType BUG= 633214 Review-Url: https://codereview.chromium.org/2202143002 Cr-Commit-Position: refs/heads/master@{#409225} [modify] https://crrev.com/909e62f21bef265278f12a398af788e2c02060f8/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
,
Aug 2 2016
Looks like the bots have cycled the change now, and Nexus 5, Nexus 9, pixel C doesn't have this problem any more.
,
Aug 2 2016
Thanks Xida for following up on this. We should add the WebGL conformance tests on Android (Nexus 5X) to the Chromium CQ. Let's discuss with the infra team.
,
Jun 20 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by cwallez@chromium.org
, Aug 1 2016