New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633198 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 631953
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-1.4% regression in system_health.memory_desktop at 407739:407779

Project Member Reported by petrcermak@chromium.org, Aug 1 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=633198

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg-sfaqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghqPdsAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghu6fuAoM


Bot(s) for this bug's original alert(s):

chromium-rel-win10
chromium-rel-win7-gpu-intel
chromium-rel-win7-x64-dual

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@407760  6309973  31989.8  12  good
chromium@407766  6296777  11159.7  8   bad

Bisect job ran on: winx64_10_perf_bisect
Bug ID: 633198

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_news-memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/load_news_qq
Relative Change: 0.35%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/627
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005528778535605456


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5774912443121664

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 631953
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Unify glyph metrics to use the same Skia API
Author  : drott
Commit description:
  
Use identical glyph metrics based bounds in HarfBuzz callbacks as well
as ShapeResult's glyph bounds calculation, except on Mac, due to Skia
bug https://bugs.chromium.org/p/skia/issues/detail?id=5328

* Using the same glyph bounds callback in HarfBuzz shaping and in
  ShapeResult's glyph bounds calculation enables reusing of the same
  cache in Skia, as opposed to using the cached glyph metrics based
  cache vs. using a second cache for path based metrics before.

Local benchmarking of the blink_perf.layout shows 12.44%
improvements for the character_fallback test and 1.8-5%
improvements on chapter-reflow-once, line-layout and
latin-complex-test. There are also some hits on flexbox-lots of
data and flexbox-row-nowrap. I am not 100% convinced that the
local benchmarks are accurate enough and would like to observe
the results on the bot. Overall, we should see a layout speed
improvement, perhaps even in the page cyclers.

BUG= 610313 
R=kojii,tzik

Review-Url: https://codereview.chromium.org/1980913002
Cr-Commit-Position: refs/heads/master@{#407755}
Commit  : 9e47ba024f0061ea667565451c2842f66813fee7
Date    : Tue Jul 26 09:59:36 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@407738  9061212  12756.9  5  good
chromium@407747  9050563  8493.65  5  good
chromium@407751  9047286  3426.96  5  good
chromium@407753  9044828  25808.1  5  good
chromium@407754  9054659  30733.7  5  good
chromium@407755  9197199  6211.89  5  bad    <--
chromium@407774  9193103  2243.47  5  bad
chromium@407809  9183273  19856.1  5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 633198

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_news-memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/load_news_wikipedia
Relative Change: 1.35%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1100
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005162180871071632


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5778723287072768

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment