New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633191 link

Starred by 4 users
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Mar 2017
Cc:
fbeaufort@chromium.org
jlebel@chromium.org
█ ortuno@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature

Blocked on:
issue 682583
Blocking:
issue 364359
issue 673147



Sign in to add a comment

bluetooth: mac: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications

Reported by tom...@opera.com, Aug 1 2016 
Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications and UnsubscribeFromNotifications. Also remove the override of StartNotifySession so that the platform-independent version is used.

See BluetoothRemoteGattCharacteristicAndroid for an example of how this can be done.

Comment 1 by tom...@opera.com, Aug 10 2016

Summary: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications for Mac (was: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications)

Comment 2 by tom...@opera.com, Aug 10 2016

Blockedon: 624017

Comment 3 by scheib@chromium.org, Aug 12 2016

Status: Available (was: Untriaged)

Comment 4 by scheib@chromium.org, Aug 12 2016

Blocking: 364359

Comment 5 by scheib@chromium.org, Aug 12 2016

Summary: bluetooth: mac: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications (was: Implement BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications for Mac)

Comment 6 by tom...@opera.com, Aug 23 2016

Blocking: 545682

Comment 7 by tom...@opera.com, Aug 23 2016

Blocking: -545682

Comment 8 by ortuno@chromium.org, Dec 11 2016

Blocking: 673147
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/230ba260170c6d7ab48a72a5f0eea01be95740f3

commit 230ba260170c6d7ab48a72a5f0eea01be95740f3
Author: jlebel <jlebel@chromium.org>
Date: Sun Jan 15 23:36:22 2017

Bluetooth: macOS: Replacing BluetoothRemoteGattCharacteristicMac::StartNotifySession()
by BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications().

BUG= 633191 

Review-Url: https://codereview.chromium.org/2599303002
Cr-Commit-Position: refs/heads/master@{#443820}

[modify] https://crrev.com/230ba260170c6d7ab48a72a5f0eea01be95740f3/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/230ba260170c6d7ab48a72a5f0eea01be95740f3/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/230ba260170c6d7ab48a72a5f0eea01be95740f3/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e9555b9c26f6c667eee3ffd471f92caa8cb196

commit c6e9555b9c26f6c667eee3ffd471f92caa8cb196
Author: pkalinnikov <pkalinnikov@chromium.org>
Date: Mon Jan 16 14:27:42 2017

Revert of Bluetooth: macOS: BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications (patchset #3 id:120001 of https://codereview.chromium.org/2599303002/ )

Reason for revert:
6 BluetoothRemoteGattCharacteristicTest's, e.g., BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged, are getting time out on "Mac10.10 Tests" and "Mac10.11 Tests" builders.

Original issue's description:
> Bluetooth: macOS: Replacing BluetoothRemoteGattCharacteristicMac::StartNotifySession()
> by BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications().
>
> BUG= 633191 
>
> Review-Url: https://codereview.chromium.org/2599303002
> Cr-Commit-Position: refs/heads/master@{#443820}
> Committed: https://chromium.googlesource.com/chromium/src/+/230ba260170c6d7ab48a72a5f0eea01be95740f3

TBR=scheib@chromium.org,fbeaufort@chromium.org,jlebel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 633191 

Review-Url: https://codereview.chromium.org/2638753002
Cr-Commit-Position: refs/heads/master@{#443891}

[modify] https://crrev.com/c6e9555b9c26f6c667eee3ffd471f92caa8cb196/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/c6e9555b9c26f6c667eee3ffd471f92caa8cb196/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/c6e9555b9c26f6c667eee3ffd471f92caa8cb196/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm

Comment 11 by ortuno@chromium.org, Jan 19 2017

Blockedon: 682583
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06715722249119894485b423b3bdeda2c18d60b

commit b06715722249119894485b423b3bdeda2c18d60b
Author: jlebel <jlebel@chromium.org>
Date: Fri Jan 20 00:52:33 2017

Bluetooth: macOS: Replacing BluetoothRemoteGattCharacteristicMac::StartNotifySession() by BluetoothRemoteGattCharacteristicMac::SubscribeToNotifications().

BUG= 633191 

Review-Url: https://codereview.chromium.org/2599303002
Cr-Commit-Position: refs/heads/master@{#443820}
Committed: https://chromium.googlesource.com/chromium/src/+/230ba260170c6d7ab48a72a5f0eea01be95740f3

patch from issue 2599303002 at patchset 120001 (http://crrev.com/2599303002#ps120001)

Review-Url: https://codereview.chromium.org/2632253003
Cr-Commit-Position: refs/heads/master@{#444899}

[modify] https://crrev.com/b06715722249119894485b423b3bdeda2c18d60b/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/b06715722249119894485b423b3bdeda2c18d60b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/b06715722249119894485b423b3bdeda2c18d60b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c346d76dbf749c72ef9733e4befd2845fcf6935

commit 7c346d76dbf749c72ef9733e4befd2845fcf6935
Author: jlebel <jlebel@chromium.org>
Date: Tue Feb 14 08:54:42 2017

Bluetooth: macOS: Implement BluetoothRemoteGattCharacteristicMac::UnsubscribeFromNotifications

BUG= 633191 

Review-Url: https://codereview.chromium.org/2634873002
Cr-Commit-Position: refs/heads/master@{#450295}

[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/test/bluetooth_test_mac.h
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm
[modify] https://crrev.com/7c346d76dbf749c72ef9733e4befd2845fcf6935/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm

Comment 14 by fbeaufort@chromium.org, Mar 1 2017

Blockedon: -624017

Comment 15 by ortuno@chromium.org, Mar 4 2017

Owner: jlebel@chromium.org
Status: Fixed (was: Available)

Comment 16 by jlebel@chromium.org, Apr 29 2017

Cc: jlebel@chromium.org fbeaufort@chromium.org ortuno@chromium.org
 Issue 624019  has been merged into this issue.
►

Sign in to add a comment