New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633187 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1% regression in system_health.memory_desktop at 408600:408611

Project Member Reported by petrcermak@chromium.org, Aug 1 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=633187

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuOLvgsM


Bot(s) for this bug's original alert(s):

linux-release

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@408599  3365115  9819.45  12  good
chromium@408611  3370717  9182.94  8   bad

Bisect job ran on: linux_perf_bisect
Bug ID: 633187

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_games_lazors
Relative Change: 0.20%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6615
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005529401529012064


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5910473422143488

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: cbruni@chromium.org
Owner: cbruni@chromium.org

=== Auto-CCing suspected CL author cbruni@chromium.org ===

Hi cbruni@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [api] Introduce fast instantiations cache
Author  : cbruni
Commit description:
  
This CL introduces a new fast flat instantiations cache for the first 1024 object templates.
After that we fall back to the existing slower dictionary cache.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217

Review-Url: https://codereview.chromium.org/2170743003
Cr-Commit-Position: refs/heads/master@{#38146}
Commit  : f3f738fe8e670f95e003656f671f18c6095533cc
Date    : Thu Jul 28 17:19:52 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@408599                3368848  7236.87  5  good
chromium@408611                3370024  8857.54  5  good
chromium@408617                3374146  10980.0  5  good
chromium@408620                3367774  8732.18  5  good
chromium@408621                3373315  10590.0  5  good
chromium@408621,v8@70489a1be5  3368123  10102.3  5  good
chromium@408621,v8@e063b7118c  3377000  2001.34  5  good
chromium@408621,v8@f3f738fe8e  3398082  8595.1   5  bad    <--
chromium@408621,v8@4f0029a481  3386339  9811.2   5  bad
chromium@408621,v8@b9e9e84671  3398912  7908.64  5  bad
chromium@408622                3392702  12137.4  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 633187

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_games_lazors
Relative Change: 0.71%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6622
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005161285626015936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5868855423926272

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
I've introduce a new instantiations cache of size 1024 which is lazily allocated.
I'll investigate why this didn't reduce the pressure (and size) on the slow case.

Comment 7 by cbruni@chromium.org, Aug 10 2016

Cc: littledan@chromium.org ahaas@chromium.org j...@ca.ibm.com neis@chromium.org petrcermak@chromium.org verwa...@chromium.org l...@chromium.org machenb...@chromium.org
 Issue 635925  has been merged into this issue.
Perf sheriff ping: reminder to follow up on possible performance issues
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff
Labels: Hotlist-SystemHealthBankruptcy
Status: Archived (was: Assigned)
Temporarily declaring bankruptcy on the *desktop* system health benchmark.
The number of alerts became unmanageable and the overall process needs to be improved to make it sustainable.
The alerts have been turned off and I'm archiving the outstanding regressions.
Note: this is just about desktop, the mobile system health stays up. 

Sign in to add a comment