New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633180 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

History search field should receive focus initially

Reported by cyril.au...@gmail.com, Aug 1 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2810.2 Safari/537.36

Steps to reproduce the problem:
1. open history: ctrl+H
2. start typing
3. 

What is the expected behavior?
it should type in the search field (like it used to chromium<54)

What went wrong?
nothing happens

Did this work before? N/A 

Chrome version: 54.0.2810.2  Channel: dev
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

This is really a regression for me, history is much less usable like that
 
Cc: tsergeant@chromium.org calamity@chromium.org bettes@chromium.org
Components: -UI UI>Browser>History
Labels: Proj-MaterialDesign-WebUI
Status: Available (was: Unconfirmed)
Labels: -Pri-2 Pri-1
Owner: calamity@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ee9e02331eeaced2a8a74c8abc6a5c6106d283

commit 70ee9e02331eeaced2a8a74c8abc6a5c6106d283
Author: calamity <calamity@chromium.org>
Date: Fri Aug 19 10:54:11 2016

[MD History] Focus the search bar on load.

This CL causes the search field on the MD History page to focus on load.
It also keeps the placeholder text visible while the search field is
empty.

BUG= 633180 
NOPRESUBMIT=true # crisper.js
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2237703004
Cr-Commit-Position: refs/heads/master@{#413101}

[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/70ee9e02331eeaced2a8a74c8abc6a5c6106d283/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Status: Fixed (was: Available)

Sign in to add a comment