New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633175 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Circular border of profile picture appears frayed/pixelated.

Reported by yfulgaon...@etouch.net, Aug 1 2016

Issue description

Version: 54.0.2815.0 (Official Build) b04cd370dcb7e737fe32d3c8a0f12daa59fa85f8-refs/heads/master@{#408889} (64-bit)
OS: Mac (10.10.5, 10.11.5)

What steps will reproduce the problem?
1. Launch chrome and click on Avatar icon.
2. Now click and hold Profile picture, observe the circular border of Profile picture.

Actual : After step 2, circular border of profile picture appears frayed/pixelated.

Expected : Circular border of profile picture should appear sharp.

This is a regression issue broken in M-54, below is Manual Regression and Narrow Bisect info.

Good build: 54.0.2801.0
Bad build: 54.0.2802.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/8cc17dd5bd16119157decba981d11f1e217052dd..e6fcf92ec826c6b56672eec154e2075b1d01cf60?pretty=fuller&n=100

Suspecting: r406377 from Narrow Bisect

Note : This is mac specific issue and not seen on Windows, Linux OS.

@janeliulwq : Can you please take a look
 
Act_Exp.png
67.3 KB View Download
Actual.mov
5.0 MB Download

Comment 1 by ew...@chromium.org, Aug 8 2016

Labels: md-usermenu
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2995fb57c078db3de42e5ad46faf5ad428e80d

commit bd2995fb57c078db3de42e5ad46faf5ad428e80d
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Aug 11 14:29:24 2016

[Mac][MD User Menu] UI Tweaks

Specifically:
1. Fixed misalignment between user menu and avatar button (see bug #1)
2. Fixed pixelated profile icon border (see  bug #2 )
3. Fixed certain letters being cut off on the bottom for avatar name
4. Disabled the color change for button icons upon mouse down
5. Disabled focus for buttons that are disabled (see  bug #3 )

See comparative screenshots:
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGWUtYM29OdnVjQm8

BUG= 632936 
BUG= 633175 
BUG= 633877 

BUG= 615893 

Review-Url: https://codereview.chromium.org/2197253002
Cr-Commit-Position: refs/heads/master@{#411323}

[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The above CL should be able to address this issue.

Comment 4 by ew...@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
Marking as fixed (by above CL).

Sign in to add a comment