Version: 54.0.2815.0 OS: Mac On Mac the margins between icons on the RHS of the omnibox look tighter than in the spec: https://spec.googleplex.com/chrome/components/omnibox.html#omnibox-permissions-extensions. The layout seems to be correct on Windows or Chrome OS.
Please use the updated spec including hover/click/active/focused states: Chrome UX specs and sources > Chrome Omnibox & Security > Non-Touch (https://drive.google.com/file/d/0B6Wxmj9LZL6XOEhOMjlybGd6QkE/view). Thanks!
Can I take this shrike? Thanks
Yes, thank you.
CL in review: https://codereview.chromium.org/2471583002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c commit f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c Author: spqchan <spqchan@chromium.org> Date: Thu Nov 03 18:38:02 2016 [Mac] Change the omnibox decoration padding - Fixed the spacing for the RHS omnibox icons - Changed how the LHS omnibox icon paddings are calculated so that it will be easier to draw a hover background in a follow up CL. - NOTE: the LHS omnibox icons spacing shouldn't be changed. BUG= 633156 , 588377 Review-Url: https://codereview.chromium.org/2471583002 Cr-Commit-Position: refs/heads/master@{#429658} [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/image_decoration.mm [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h [modify] https://crrev.com/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
Tested the same on mac 10.11.6 chrome version 56.0.2913.3 - observed that the omnibox icons looks fine compared to version 54.0.2815.0 Please find the screenshot
Comment 1 by shrike@chromium.org
, Aug 1 2016Labels: M-54
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)