New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633136 link

Starred by 3 users
Status: Fixed
Owner:
tmonius...@opera.com
Closed: Sep 2016
Cc:
█ chongz@chromium.org
pkasting@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 624527


Sign in to add a comment

TextfieldTest.KeysWithModifiersTest fails with non US keyboard layout

Project Member Reported by tmonius...@opera.com, Aug 1 2016 
OS: Win 7

(1) Set non US keyboard layout as the default in system. Choose keyboard layout that uses modifier keys for inserting special characters: for example Polish.
(2) Run views_unittests.exe

TextfieldTest.KeysWithModifiersTest test fails with following output:

[ RUN      ] TextfieldTest.KeysWithModifiersTest
e:\sources\chromium\src\ui\views\controls\textfield\textfield_unittest.cc(800): error: Value of: textfield_->text()
  Actual: L"T\x119T\x118x234"
Expected: ASCIIToUTF16("TeTEx234")
Which is: L"TeTEx234"
[  FAILED  ] TextfieldTest.KeysWithModifiersTest (30 ms)

This is a regression introduced in https://chromium.googlesource.com/chromium/src/+/d63b5218dab7a9675f8de0842c0f3ac5febcb94f

Comment 1 by tmonius...@opera.com, Sep 16 2016

Blockedon: 624527
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19cb1e03c46a4df0c0fd54171369152bcb19c237

commit 19cb1e03c46a4df0c0fd54171369152bcb19c237
Author: tmoniuszko <tmoniuszko@opera.com>
Date: Mon Sep 19 14:47:37 2016

Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

BUG= 633136 

Review-Url: https://codereview.chromium.org/2197113002
Cr-Commit-Position: refs/heads/master@{#419454}

[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/chrome/test/chromedriver/key_converter_unittest.cc
[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/chrome/test/chromedriver/keycode_text_conversion_unittest.cc
[delete] https://crrev.com/a7e4b7e260983b75067aacdbd55c5182675c4829/chrome/test/chromedriver/test_util.cc
[delete] https://crrev.com/a7e4b7e260983b75067aacdbd55c5182675c4829/chrome/test/chromedriver/test_util.h
[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/BUILD.gn
[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/keycodes/platform_key_map_win_unittest.cc
[add] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/test/keyboard_layout.cc
[add] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/test/keyboard_layout.h
[add] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/test/keyboard_layout_mac.cc
[add] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/events/test/keyboard_layout_win.cc
[modify] https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237/ui/views/controls/textfield/textfield_unittest.cc

Comment 3 by tmonius...@opera.com, Sep 19 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035c1ea19a2a12540f20c975a0c34c401051f9ac

commit 035c1ea19a2a12540f20c975a0c34c401051f9ac
Author: iclelland <iclelland@chromium.org>
Date: Mon Sep 19 16:34:45 2016

Revert of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest (patchset #11 id:200001 of https://codereview.chromium.org/2197113002/ )

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)

First failed build:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/21876

Original issue's description:
> Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest
>
> BUG= 633136 
>
> Committed: https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237
> Cr-Commit-Position: refs/heads/master@{#419454}

TBR=pkasting@chromium.org,chongz@chromium.org,sadrul@chromium.org,frankf@chromium.org,wez@chromium.org,samuong@chromium.org,tmoniuszko@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 633136 

Review-Url: https://codereview.chromium.org/2349253002
Cr-Commit-Position: refs/heads/master@{#419479}

[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/chrome/test/chromedriver/key_converter_unittest.cc
[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/chrome/test/chromedriver/keycode_text_conversion_unittest.cc
[add] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/chrome/test/chromedriver/test_util.cc
[add] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/chrome/test/chromedriver/test_util.h
[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/ui/events/BUILD.gn
[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/ui/events/keycodes/platform_key_map_win_unittest.cc
[delete] https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf/ui/events/test/keyboard_layout.cc
[delete] https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf/ui/events/test/keyboard_layout.h
[delete] https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf/ui/events/test/keyboard_layout_mac.cc
[delete] https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf/ui/events/test/keyboard_layout_win.cc
[modify] https://crrev.com/035c1ea19a2a12540f20c975a0c34c401051f9ac/ui/views/controls/textfield/textfield_unittest.cc

Comment 6 by tmonius...@opera.com, Sep 20 2016

Cc: pkasting@chromium.org
iclelland@, I don't have access to locations linked from Comment 4. Is there any other way to see the reason of failures?

Comment 7 by chongz@chromium.org, Sep 20 2016 

tmoniuszko@ I've attached the error log from #4, but I'm not sure how |TISSelectInputSource| works though.

Hope it helps.
MacASAN-TextfieldTest.KeysWithModifiersTest.txt
9.3 KB View Download

Comment 8 by tmonius...@opera.com, Sep 21 2016

Status: Started (was: Fixed)
chongz@ thanks for the log!

I've created a fix: https://codereview.chromium.org/2353333002/
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a72a760dfcc8407706249417261256a0c1dc8246

commit a72a760dfcc8407706249417261256a0c1dc8246
Author: tmoniuszko <tmoniuszko@opera.com>
Date: Tue Sep 27 13:34:37 2016

Reland of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest

Reverted in
https://codereview.chromium.org/2349253002

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)

BUG= 633136 

Review-Url: https://codereview.chromium.org/2353333002
Cr-Commit-Position: refs/heads/master@{#421191}

[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/chrome/test/chromedriver/key_converter_unittest.cc
[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/chrome/test/chromedriver/keycode_text_conversion_unittest.cc
[delete] https://crrev.com/fc94b64028d13e4d54038a953038a1c7e3348ed5/chrome/test/chromedriver/test_util.cc
[delete] https://crrev.com/fc94b64028d13e4d54038a953038a1c7e3348ed5/chrome/test/chromedriver/test_util.h
[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/BUILD.gn
[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/keycodes/platform_key_map_win_unittest.cc
[add] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/test/keyboard_layout.cc
[add] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/test/keyboard_layout.h
[add] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/test/keyboard_layout_mac.cc
[add] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/events/test/keyboard_layout_win.cc
[modify] https://crrev.com/a72a760dfcc8407706249417261256a0c1dc8246/ui/views/controls/textfield/textfield_unittest.cc

Comment 10 by tmonius...@opera.com, Sep 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment