New issue
Advanced search Search tips

Issue 633099 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Empty today extension on 3D touch if pasteboard is empty

Project Member Reported by olivierrobin@chromium.org, Aug 1 2016

Issue description

If the Pasteboard is empty the today extension on force touch is empty.
We should have a placeholder there.
 
Cc: pschaffner@chromium.org
Owner: amyroberts@chromium.org
Assigning to amyroberts as pschaffner is OOO.

Labels: Proj-iOS10
See attached image for what Apple maps does when there's nothing to say
IMG_4089.PNG
856 KB View Download
Cc: justincohen@chromium.org
Labels: OS-iOS
ping
Owner: pschaffner@chromium.org
For the string, I suggest: "No Copied Link".

Specs for the label:
- layout: centered vertically (plus the height of the widget header) and horizontally in the widget
- font: system font
- size: 16
- color: black
- opacity: 40%
Owner: olivierrobin@chromium.org
What if widget is empty except for PW enable/disable?
May be part of crbug.com/633105
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e7a1ebeac57d76644eadae87e805cc0d4304fb9

commit 9e7a1ebeac57d76644eadae87e805cc0d4304fb9
Author: olivierrobin <olivierrobin@chromium.org>
Date: Wed Aug 17 14:32:04 2016

Add string for empty label in today extension.

BUG= 633099 

Review-Url: https://codereview.chromium.org/2254603003
Cr-Commit-Position: refs/heads/master@{#412519}

[modify] https://crrev.com/9e7a1ebeac57d76644eadae87e805cc0d4304fb9/ios/chrome/today_extension/strings/ios_today_extension_strings.grd

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/17cfb625840d5201a96441fd75ccffc3b07e2959

commit 17cfb625840d5201a96441fd75ccffc3b07e2959
Author: olivierrobin <olivierrobin@google.com>
Date: Thu Aug 18 07:36:14 2016

Status: Fixed (was: Assigned)
I still see the newtab/voicesearch buttons flicker in and out. 
filed crbug.com/638949 for this particular issue.
Status: Verified (was: Fixed)
When the pasteboard is empty, "No copied link" string is seen on force touch. 
Verified on iPhone 6s+(10.0.2) in 54.0.2840.39 dev 
Screenshot - https://drive.google.com/a/google.com/file/d/0B0yKxJxj4vw1OGM1WDQtR1FId2s/view?usp=sharing

Sign in to add a comment