New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633077 link

Starred by 4 users
Status: Fixed
Owner:
peria@chromium.org
Closed: Jan 2017
Cc:
█ phajdan.jr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Missing dependency from ui_test_utils.cc to interface_provider.mojom.h

Project Member Reported by tzik@chromium.org, Aug 1 2016 
ui_test_utils.cc includes interface_provider.mojom.h via:
 - chrome/test/base/ui_test_utils.cc
 - content/public/browser/render_process_host.h
 - services/shell/public/cpp/interface_registry.h
 - out/Release/gen/services/shell/public/interfaces/interface_provider.mojom.h

However, ui_test_utils.cc doesn't have the dependency to interface_provider.mojom.h, and can be compiled before interface_provider.mojom.h generation.
That causes flaky build failure on clobber build bots.

https://build.chromium.org/p/chromium/builders/Win/builds/45796 is an example.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11cac3e30beabb6878f6e50a0fd5b657582c665b

commit 11cac3e30beabb6878f6e50a0fd5b657582c665b
Author: peria <peria@chromium.org>
Date: Fri Sep 09 02:39:22 2016

Put an obvious dependency on browser from ui_test.
It is expected to fix flaky build failures in the BUG.

Using source code names, this CL adds a dependency
chrome/test/base/ui_test_utils.cc
--> content/public/browser/render_process_host.h

Other dependencies
content/public/browser/render_process_host.h
--> services/shell/public/cpp/interface_registry.h
--> out/Release/gen/services/shell/public/interfaces/interface_provider.mojom.h
are already written.

BUG= 633077 

Review-Url: https://codereview.chromium.org/2321563004
Cr-Commit-Position: refs/heads/master@{#417485}

[modify] https://crrev.com/11cac3e30beabb6878f6e50a0fd5b657582c665b/chrome/test/BUILD.gn

Comment 2 by phajdan.jr@chromium.org, Jan 5 2017

Cc: phajdan.jr@chromium.org
Owner: peria@chromium.org
Status: Fixed (was: Assigned)
Looks like it's fixed. Thanks!
►

Sign in to add a comment