New issue
Advanced search Search tips

Issue 633046 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocking:
issue 589681
issue 624165



Sign in to add a comment

MD Settings: Regression: Section height changes immediately on opening subpage

Project Member Reported by michae...@chromium.org, Aug 1 2016

Issue description

After https://codereview.chromium.org/2156413002, opening a sub-page in a section now changes the section's height immediately instead of gradually expanding from its original height.

Previously, opening a sub-page would trigger the section to begin gradually expanding, from its original height, to the height of the main page. Now, it immediately resizes to the height of the sub-page content, before expanding to the height of the main page.

Easier to test/repro by setting EXPAND_DURATION=5000 in the console.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ded0cc6677d07279b6722bd73ed0f32723d90283

commit ded0cc6677d07279b6722bd73ed0f32723d90283
Author: michaelpg <michaelpg@chromium.org>
Date: Mon Aug 01 19:14:04 2016

MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG= 633046 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2197093002
Cr-Commit-Position: refs/heads/master@{#409014}

[modify] https://crrev.com/ded0cc6677d07279b6722bd73ed0f32723d90283/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/ded0cc6677d07279b6722bd73ed0f32723d90283/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Labels: Hotlist-MD-Settings-Structure
Status: Available (was: Untriaged)
Status: Fixed (was: Available)

Sign in to add a comment