New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633044 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Buried. Ping if important.
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird report an issue overlay is seen in 54.0.2814.0

Project Member Reported by sc00335...@techmahindra.com, Aug 1 2016

Issue description

Version: 54.0.2814.0 
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Launch chrome and open report an issue from wrench menu or hit "alt+shift+i" from keyboard and observe

Expected: Close button and Send feedback button should be clear and borders should be visible.
Actual: Instead weird behavior of buttons is seen and borders are seen missing.

This is a regression issue broken in M54. Will provide other info soon.
 
Actual_report an issue.png
144 KB View Download
Labels: OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on windows 7 and Mac 10.11.6 using chrome version 54.0.2813.0.Marking it as Untriaged.

Sindhu@ Please provide bisect information.

Thanks,
Labels: ReleaseBlock-Beta
Good build: 54.0.2811.0 dev
Bad Build: 54.0.2812.0 dev

Unable to tool bisect as we don't have report an issue overlay in chromium builds.
Hence providing manual bisect info.

Cr: https://chromium.googlesource.com/chromium/src/+log/54.0.2811.0..54.0.2812.0?pretty=fuller&n=10000

Unable to find suspect from above changelog. Please help in assigning to appropriate owner.

Thanks!
Cc: kylixrd@chromium.org
Labels: -Needs-Bisect hasbisect OS-Chrome
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Suspecting https://codereview.chromium.org/2186643002 from above changelog.

@chrishtr: Please help in re-assigning to appropriate dev if it is not related to your change.

Issue is also seen in CrOS with 54.0.2813.0/8660.0.0 dev on daisy.
Cc: abodenha@chromium.org dhadd...@chromium.org sdantul...@chromium.org abod...@chromium.org
 Issue 633342  has been merged into this issue.
Owner: apaci...@chromium.org
Cc: apaci...@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I haven't made any changes to the current feedback UI; also, my changes aren't wired up yet to appear and will be behind a flag when done so.

Comment 7 by jleedev@gmail.com, Aug 2 2016

There are some error messages:

default.html:5 Refused to load the stylesheet 'chrome://resources/css/text_defaults.css' because it violates the following Content Security Policy directive: "style-src 'unsafe-inline' blob: filesystem: data: *".

default.html:6 Refused to load the stylesheet 'chrome://resources/css/apps/common.css' because it violates the following Content Security Policy directive: "style-src 'unsafe-inline' blob: filesystem: data: *".

default.html:7 Refused to load the stylesheet 'chrome://resources/css/apps/topbutton_bar.css' because it violates the following Content Security Policy directive: "style-src 'unsafe-inline' blob: filesystem: data: *".

commit 6104167b0bf16a3520a898dbe67227637d1c214e changed how * is treated.

Comment 8 by jleedev@gmail.com, Aug 2 2016

A similar error is seen while viewing a PDF:

pdf.js:230 Refused to load plugin data from 'foo.pdf' because it violates the following Content Security Policy directive: "object-src * blob: filesystem: data:".
PDFViewer @ pdf.js:230

Code search for component apps that specify a wildcard CSP: https://cs.chromium.org/search/?q=content_security_policy.*%5C+%5C*%5B+%5D&sq=package:chromium&type=cs
(Feedback and PDF are the only hits)

Comment 9 by ajha@chromium.org, Aug 2 2016

Owner: mkwst@chromium.org
Status: Assigned (was: Untriaged)
Thanks  jleedev@ for investigation.

shekyan@: Could you please take a look at this. Assigning to mkwst@ as the reviewer of the CL and unable to assign to shekyan@. 

Comment 10 by ajha@chromium.org, Aug 10 2016

Cc: nyerramilli@chromium.org ranjitkan@chromium.org
 Issue 636236  has been merged into this issue.
Issue is still seen in 54.0.2825.0 dev of linux ,windows and Mac
Actual in latest.png
206 KB View Download

Comment 12 by ajha@chromium.org, Aug 10 2016

Cc: jochen@chromium.org shek...@gmail.com mfo...@chromium.org
Looks like all the reviewers of the CL are OOO until Aug 15th.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e84bb1695f941cb15c99abc51970db0c65dc910

commit 0e84bb1695f941cb15c99abc51970db0c65dc910
Author: shekyan <shekyan@gmail.com>
Date: Wed Aug 10 23:52:01 2016

Adjust CSP of feedback extension

Recent change to Content Security Policy matching algorithm for
"*" source-expression at https://codereview.chromium.org/2209113002/
requires to adjust policies, that use "*" and assume that it will match
resource loads from schemes other than http/https/ws/wss.
Two extension manifests had to be changed, becasue they expect resources to load from `file:` and `chrome:` and are using "*", which was addressed in CL
mentioned above.
Unfortunately, I forgot to update style-src directive to
also allow resources from `chrome:` scheme. This patch set fixes that.

BUG= 633044 
R=jww@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2235833003
Cr-Commit-Position: refs/heads/master@{#411189}

[modify] https://crrev.com/0e84bb1695f941cb15c99abc51970db0c65dc910/chrome/browser/resources/feedback/manifest.json

Checked the issue on latest windows 54.0.2826.0 with revision 411209 which is greater than commit position of this  bug 411189 . Issue is still seen.

Now no "X" icon on top of overlay, no checkboxes from system information are seen. and buttons send feedback and cancel are seen faded.

If required will raise a new issue for that.

Thnaks!
In latest.png
201 KB View Download

Comment 15 by shek...@gmail.com, Aug 11 2016

Are there any error messages related to image load, similar to Comment 7 ?
Checked for errors in console.

Did these steps:  Opened report an issue overlay >> chrome://inspect/#apps >> clicked inspect of feedback. Now in console got some error messages.

Attaching screenshot of those errors.

Errors:

Refused to load the image 'chrome://resources/images/apps/topbar_button_minimize.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

default.html:1 Refused to load the image 'chrome://resources/images/apps/topbar_button_close.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

default.html:1 Refused to load the image 'chrome://resources/images/apps/button.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

default.html:1 Refused to load the image 'chrome://resources/images/apps/blue_button.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

default.html:1 Refused to load the image 'chrome://resources/images/apps/checkbox.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

default.html:1 Refused to load the image 'chrome://resources/images/apps/checkbox_checked.png' because it violates the following Content Security Policy directive: "img-src * blob: file: filesystem: data:".

feedback.js:331 'webkitRequestAnimationFrame' is vendor-specific. Please use the standard 'requestAnimationFrame' instead.(anonymous function) @ feedback.js:331

@shekyan: If there is any other way of finding for errors please mention. Will check.

Thanks!
Inspect element of feedback overlay.png
203 KB View Download

Comment 17 Deleted

Comment 18 by shek...@gmail.com, Aug 11 2016

Thanks! Created CL https://codereview.chromium.org/2236233002 to address this. 

The reason we don't see violation reports for images in Comment 7 is that stylesheets that were blocked did not attempt to load the images. After fixing the stylesheet loads, we started seeing blocked images.

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/538be9a65c081269429400de49057ede4d50bd32

commit 538be9a65c081269429400de49057ede4d50bd32
Author: shekyan <shekyan@gmail.com>
Date: Fri Aug 12 04:24:51 2016

Adjust CSP of feedback extension

Recent change to Content Security Policy matching algorithm for
"*" source-expression at https://codereview.chromium.org/2209113002/
requires to adjust policies that use "*" and assume that it will match
resource loads from schemes other than http/https/ws/wss.

This patch set updates img-src CSP directive of feedback extension
to allow loading images from `chrome:` scheme.

BUG= 633044 
R=jww@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2236233002
Cr-Commit-Position: refs/heads/master@{#411551}

[modify] https://crrev.com/538be9a65c081269429400de49057ede4d50bd32/chrome/browser/resources/feedback/manifest.json

Is this fixed?  This is currently a beta blocker and M54's branch point is coming up.

Comment 21 by shek...@gmail.com, Aug 16 2016

Should be. 
Cc: rookrishna@chromium.org
 Issue 637434  has been merged into this issue.
Cc: kuscher@chromium.org
Checked the issue on  54.0.2837.0 dev of linux,windows and 54.0.2831.0/8731.0.0 of CrOS and is got fixed.

Comment 25 by ajha@chromium.org, Aug 23 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2837.0
Status: Fixed (was: Assigned)
Tested the same on Mac OS 10.11.6 on chrome version: 54.0.2837.0 and this is working as intended. Hence marking this as Fixed and adding verified label.


Status: Verified (was: Fixed)

Sign in to add a comment