New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633043 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: No gap appears between Cookies list item and "Clear and reset" paper button

Reported by lpa...@etouch.net, Aug 1 2016 
Chrome Version: 54.0.2814.0 (Official Build) e0d4e8e3266cc2a7b8dcecfeff30ce101eac9a8b-refs/heads/master@{#408878} (64-bit)
OS: Windows(7,8,8.1,10)

Steps:
1. Launch chrome and navigate to chrome://md-settings/siteSettings/cookies.
2. Set up and exception and go to chrome://md-settings/siteSettings/cookies/details.
3. Observe the "Clear and reset" button.

Actual  : No gap appears between Cookies list item and "Clear and reset" paper button.
Expected: Sufficient gap should appear between them.

This is a regression issue broken in 'M-54' and will soon update Bisect and OS info.

Comment 1 by lpa...@etouch.net, Aug 1 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Regression range
Good Build: 54.0.2813.0
Bad Build : 54.0.2814.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/19f44a11dcc5866c52e86bee2eab07149d06ddd0..fa2a0564521839e12c4c1e53b923e5cafb30c1e2?pretty=fuller&n=1000

Suspecting: r408841

Note: Issue is also seen on Linux (14.04 LTS), Mac OS X(10.10.5, 10.11.4)
Actual_Spacing.png
8.3 KB View Download
Expected_Spacing.png
7.4 KB View Download

Comment 2 by ligim...@chromium.org, Aug 1 2016

Labels: ReleaseBlock-Stable
Regressed in M54, tagging in RBS, so that the bug will be in our triaging queue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a332231ff426890f175933a02e2fa3efdcdfff70

commit a332231ff426890f175933a02e2fa3efdcdfff70
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Aug 04 20:22:00 2016

[MD settings] layout of site details permissions

This CL changes the layout of the site settings details to better match
the mocks. The Clear and reset button is changed style; the url is in
the subpage title; and the indentation is corrected.

BUG=627998,  633043 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2201243002
Cr-Commit-Position: refs/heads/master@{#409886}

[modify] https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/a332231ff426890f175933a02e2fa3efdcdfff70/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 4 by dschuyler@chromium.org, Aug 4 2016

Status: Fixed (was: Assigned)

Comment 5 by ashej...@chromium.org, Aug 9 2016

Labels: TE-Verified-54.0.2823.0 TE-Verified-M54 TE-Verified-54.0.2824.0
Retested the above issue on Windows & Ubuntu 14.04 with chrome version - 54.0.2824.0 (Windows) & 54.0.2823.0 (Ubuntu 14.04) and Gap is observed between cookies and "save & reset" button. The UI has change a bit earlier "Save & Reset" used to display as button not its link. 

Hence marking the same as TE-Verified-54.0.2824.0 & TE-Verified-54.0.2823.0.

Attach is the screenshot for the same.


Thank you!
Screen Shot 2016-08-09 at 4.22.16 PM.png
32.3 KB View Download
►

Sign in to add a comment